Chromium Code Reviews
Help | Chromium Project | Sign in
(1151)

Issue 5689005: Land Vitaly's change to fix compare IC performance.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by fschneider
Modified:
2 years, 10 months ago
Reviewers:
Vyacheslav Egorov
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Land Vitaly's change to fix compare IC performance.

Original change: http://codereview.chromium.org/5733004/

When we have inlined smi code can transition to heap number state before going to the generic state. Without inlined smi code the behaviour is unchanged.


Committed: http://code.google.com/p/v8/source/detail?r=5975

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Lint Patch
M src/ia32/ic-ia32.cc View 1 chunk +12 lines, -1 line 0 comments 0 errors Download
M src/ic.h View 1 chunk +2 lines, -1 line 1 comment 0 errors Download
M src/ic.cc View 1 chunk +7 lines, -4 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
fschneider
3 years, 4 months ago #1
Vyacheslav Egorov
3 years, 4 months ago #2
LGTM

http://codereview.chromium.org/5689005/diff/1/src/ic.h
File src/ic.h (right):

http://codereview.chromium.org/5689005/diff/1/src/ic.h#newcode585
src/ic.h:585: State TargetState(State state, bool has_inlined_smi_code,
we do not format arguments this way.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6