Do not open or close IOHIDManager's IOHIDDeviceRefs.

Do not open or close IOHIDManager's IOHIDDeviceRefs.

The IOHIDManager object manages the IOHIDDevice instances that it
creates. Calling IOHIDDeviceOpen on such an instance is a no-op and
calling IOHIDDeviceClose prevents the IOHIDManager from tracking the
lifetime of the device. The solution is to never open nor close these
devices.

BUG=413976
Committed: https://crrev.com/7b245aba250436867e5fd4dff77c08b9c5dc1a9d
Cr-Commit-Position: refs/heads/master@{#294735}

[Reilly Grant (use Gerrit), 2014-09-13 01:26:09]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2014-09-13 01:36:17]

lgtm pending resolution of inline comment

https://codereview.chromium.org/568873003/diff/1/device/hid/hid_connection_ma...
File device/hid/hid_connection_mac.cc (right):

https://codereview.chromium.org/568873003/diff/1/device/hid/hid_connection_ma...
device/hid/hid_connection_mac.cc:38: IOHIDDeviceRegisterInputReportCallback(
Can you please comment on why this is done? I do not understand.

[Reilly Grant (use Gerrit), 2014-09-13 05:05:05]

https://codereview.chromium.org/568873003/diff/1/device/hid/hid_connection_ma...
File device/hid/hid_connection_mac.cc (right):

https://codereview.chromium.org/568873003/diff/1/device/hid/hid_connection_ma...
device/hid/hid_connection_mac.cc:38: IOHIDDeviceRegisterInputReportCallback(
On 2014/09/13 01:36:17, Ken Rockot wrote:
> Can you please comment on why this is done? I do not understand.

Registering a NULL callback clears the input report callback this is necessary
so that no callbacks occur after the HidConnectMac has been freed.

[Reilly Grant (use Gerrit), 2014-09-13 05:20:47]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2014-09-13 05:21:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/568873003/20001

[commit-bot: I haz the power, 2014-09-13 06:18:32]

Committed patchset #2 (id:20001) as 035c80d41d0c27d24ffb721db1ee626679eac68b

[commit-bot: I haz the power, 2014-09-13 06:20:20]

Patchset 2 (id:??) landed as
https://crrev.com/7b245aba250436867e5fd4dff77c08b9c5dc1a9d
Cr-Commit-Position: refs/heads/master@{#294735}

[Marius, 2014-09-15 18:14:54]

mschilder@google.com changed reviewers:
+ mschilder@google.com

[Marius, 2014-09-15 18:14:54]

verified using 39.0.2159.0