device/hid/hid_connection_mac.h - Issue 568873003: Do not open or close IOHIDManager's IOHIDDeviceRefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/hid/hid_connection_mac.h

Issue 568873003: Do not open or close IOHIDManager's IOHIDDeviceRefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a comment explaining the NULL callback. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/hid/hid_connection_mac.h

diff --git a/device/hid/hid_connection_mac.h b/device/hid/hid_connection_mac.h

index 81153b6bfd5f474b1ad94adff418d9e10acc8b3b..7282760ecb128ada613c20a8757e17429de44397 100644

--- a/device/hid/hid_connection_mac.h

+++ b/device/hid/hid_connection_mac.h

@@ -62,7 +62,7 @@ class HidConnectionMac : public HidConnection {

base::ScopedCFTypeRef<IOHIDDeviceRef> device_;

scoped_refptr<base::MessageLoopProxy> message_loop_;

- scoped_ptr<uint8_t[]> inbound_buffer_;

+ std::vector<uint8_t> inbound_buffer_;

std::queue<PendingHidReport> pending_reports_;

std::queue<PendingHidRead> pending_reads_;

« no previous file with comments | « no previous file | device/hid/hid_connection_mac.cc » ('j') | no next file with comments »