Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 568843002: Fix scaling issue with distance field text. (Closed)

Created:
6 years, 3 months ago by jvanverth1
Modified:
6 years, 3 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix scaling issue with distance field text. Picks the correct distance field size based on both the text size and the max matrix scale. Adjusts the matrix scale if non-unity. Also adds GM for verifying proper distance field scaling. BUG=skia:2928 Committed: https://skia.googlesource.com/skia/+/9564ce60a657acce89fb956deb8645b324eaad1e

Patch Set 1 #

Patch Set 2 : Change scaled text GM to be a general distance field text GM. #

Patch Set 3 : Some clean up #

Patch Set 4 : Fix uninitialized variables. #

Total comments: 6

Patch Set 5 : Address comments. #

Patch Set 6 : Fix NOGPU builds #

Patch Set 7 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+845 lines, -660 lines) Patch
A gm/dftext.cpp View 1 2 3 4 5 1 chunk +165 lines, -0 lines 0 comments Download
M gm/fontscaler.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 4 5 6 1 chunk +671 lines, -656 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 2 3 4 5 6 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jvanverth1
6 years, 3 months ago (2014-09-12 17:45:40 UTC) #2
bsalomon
lgtm w/ some questions https://codereview.chromium.org/568843002/diff/60001/gm/dftext.cpp File gm/dftext.cpp (right): https://codereview.chromium.org/568843002/diff/60001/gm/dftext.cpp#newcode23 gm/dftext.cpp:23: return kSkipTiled_Flag | kGPUOnly_Flag; why ...
6 years, 3 months ago (2014-09-15 13:33:19 UTC) #3
jvanverth1
https://codereview.chromium.org/568843002/diff/60001/gm/dftext.cpp File gm/dftext.cpp (right): https://codereview.chromium.org/568843002/diff/60001/gm/dftext.cpp#newcode23 gm/dftext.cpp:23: return kSkipTiled_Flag | kGPUOnly_Flag; On 2014/09/15 13:33:19, bsalomon wrote: ...
6 years, 3 months ago (2014-09-15 13:43:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568843002/120001
6 years, 3 months ago (2014-09-16 12:37:07 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 12:45:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as 9564ce60a657acce89fb956deb8645b324eaad1e

Powered by Google App Engine
This is Rietveld 408576698