Source/bindings/templates/dictionary_v8.cpp - Issue 568703002: IDL: Values for dictionaries should be a object, null or undefined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/dictionary_v8.cpp

Issue 568703002: IDL: Values for dictionaries should be a object, null or undefined (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/dictionary_v8.cpp

diff --git a/Source/bindings/templates/dictionary_v8.cpp b/Source/bindings/templates/dictionary_v8.cpp

index 4a18170cb29058d92729815863db2bfd84510c02..fc0bac90bb8ae7a6721222ef7200e14efc3455bc 100644

--- a/Source/bindings/templates/dictionary_v8.cpp

+++ b/Source/bindings/templates/dictionary_v8.cpp

@@ -15,6 +15,8 @@ namespace blink {

{{cpp_class}}* {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Handle<v8::Value> v8Value, ExceptionState& exceptionState)

{

+ ASSERT(isUndefinedOrNull(v8Value) || v8Value->IsObject());

{{cpp_class}}* impl = {{cpp_class}}::create();

// FIXME: Do not use Dictionary and DictionaryHelper

// https://crbug.com/321462

« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »