Source/bindings/scripts/v8_methods.py - Issue 568703002: IDL: Values for dictionaries should be a object, null or undefined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 568703002: IDL: Values for dictionaries should be a object, null or undefined (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 9f9e23c9d4a3a1c9f37f789fef9d17f515aab779..dcd04ae097f1bf7a9dd2002e9d26a6c925f4d9dd 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -253,6 +253,8 @@ def argument_context(interface, method, argument, index):

'idl_type_object': idl_type,

'index': index,

'is_callback_interface': idl_type.is_callback_interface,

+ # FIXME: Remove generic 'Dictionary' special-casing

+ 'is_dictionary': idl_type.is_dictionary or idl_type.base_type == 'Dictionary',

'is_nullable': idl_type.is_nullable,

'is_optional': argument.is_optional,

'is_variadic_wrapper_type': is_variadic_wrapper_type,

« no previous file with comments | « LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt ('k') | Source/bindings/templates/dictionary_v8.cpp » ('j') | no next file with comments »