Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 568673004: [Telemetry] Increase timeout for HasBrowserFinishedLaunching (Closed)

Created:
6 years, 3 months ago by jeremy
Modified:
6 years, 3 months ago
Reviewers:
nednguyen, marja
CC:
chromium-reviews, telemetry+watch_chromium.org, tonyg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Increase timeout for HasBrowserFinishedLaunching Empirically it can take chrome up to 40 seconds to come up for a cold start on the 10.6 bots. Increase the timeout in Telemetry to reduce test flakiness. BUG=405386 Committed: https://crrev.com/6ed88af6fd662b3c1fbbaa16d36aeaf13f4a37d6 Cr-Commit-Position: refs/heads/master@{#295248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jeremy
Ned/Marja: Owner review please, whoever gets to this first...
6 years, 3 months ago (2014-09-17 07:30:50 UTC) #2
marja
lgtm; Routing some not-really-offline discussion here: it's a bit surprising (to me) that it takes ...
6 years, 3 months ago (2014-09-17 07:36:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568673004/1
6 years, 3 months ago (2014-09-17 07:39:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0f4a1101dfd1d3e935068edb06ba6782921479a3
6 years, 3 months ago (2014-09-17 09:05:05 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 09:05:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ed88af6fd662b3c1fbbaa16d36aeaf13f4a37d6
Cr-Commit-Position: refs/heads/master@{#295248}

Powered by Google App Engine
This is Rietveld 408576698