tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py - Issue 568673004: [Telemetry] Increase timeout for HasBrowserFinishedLaunching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 568673004: [Telemetry] Increase timeout for HasBrowserFinishedLaunching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

index 50d16f5dc8e0f4dc5607f6a3f39723295d4913d1..af19abd87b41af0b56168d85b42333d92ffafd26 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

@@ -144,7 +144,7 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

def _WaitForBrowserToComeUp(self, wait_for_extensions=True):

try:

- util.WaitFor(self.HasBrowserFinishedLaunching, timeout=30)

+ util.WaitFor(self.HasBrowserFinishedLaunching, timeout=50)

except (util.TimeoutException, exceptions.ProcessGoneException) as e:

if not self.IsBrowserRunning():

raise exceptions.BrowserGoneException(self.browser, e)

« no previous file with comments | « no previous file | no next file » | no next file with comments »