Upstream changes for android signin promo

Upstream changes for android signin promo

1. add uma metrics related to the new android signin promo
2. add a method to SigninManager to get the finch experiment for promo

Downstream changes at https://chrome-internal-review.googlesource.com/#/c/175857/

BUG=406614
TBR=rogerta@chromium.org

Committed: https://crrev.com/37fa0e5170b4ae065c2aaced04516600e25bcd2e
Cr-Commit-Position: refs/heads/master@{#294682}

[guohui, 2014-09-11 22:38:15]

Patchset #1 (id:1) has been deleted

[guohui, 2014-09-11 22:38:54]

guohui@chromium.org changed reviewers:
+ aruslan@chromium.org, asvitkine@chromium.org

[guohui, 2014-09-11 22:40:46]

Hey,

could you please review the CL?

Thanks,

Hui

[aruslan, 2014-09-12 01:08:03]

lgtm

[Alexei Svitkine (slow), 2014-09-12 15:36:20]

https://codereview.chromium.org/568603002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
(right):

https://codereview.chromium.org/568603002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java:403:
FieldTrialList.findFullName("AndroidSigninPromo");
Have you considered using experiment params to control this behavior, instead of
the group name?

IMHO, it would be better to have the name be human readable (i.e. when analyzing
results on dashboard) while you can use an integer as the experiment param for
this.

go/finch-params for more details on experiment params and there is a Java API
for them.

[guohui, 2014-09-12 18:07:49]

https://codereview.chromium.org/568603002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
(right):

https://codereview.chromium.org/568603002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java:403:
FieldTrialList.findFullName("AndroidSigninPromo");
as discussed offline, it is not possible to force experiment params through
command line yet, so for easier testing, i keep using groups names here. Will
try to add this feature to finch next week and update this code.

Thanks!

[Alexei Svitkine (slow), 2014-09-12 18:11:20]

https://codereview.chromium.org/568603002/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/568603002/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:29351: +<histogram
name="Signin.AndroidSigninPromo" enum="AndroidSigninPromoAction">
I'm confused - where's the code for this histogram?

Is it in another CL?

[guohui, 2014-09-12 18:12:50]

On 2014/09/12 18:11:20, Alexei Svitkine wrote:
>
https://codereview.chromium.org/568603002/diff/40001/tools/metrics/histograms...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/568603002/diff/40001/tools/metrics/histograms...
> tools/metrics/histograms/histograms.xml:29351: +<histogram
> name="Signin.AndroidSigninPromo" enum="AndroidSigninPromoAction">
> I'm confused - where's the code for this histogram?
> 
> Is it in another CL?

It is in the downstream CL in the description
https://chrome-internal-review.googlesource.com/#/c/175857/.

Specifically it is used in file
https://chrome-internal-review.googlesource.com/#/c/175857/9/native/framework....

[Alexei Svitkine (slow), 2014-09-12 19:00:15]

lgtm

[guohui, 2014-09-12 19:03:12]

The CQ bit was checked by guohui@chromium.org

[commit-bot: I haz the power, 2014-09-12 19:38:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/568603002/40001

[commit-bot: I haz the power, 2014-09-12 21:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 21:32:42]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[guohui, 2014-09-12 21:43:24]

The CQ bit was checked by guohui@chromium.org

[commit-bot: I haz the power, 2014-09-12 21:44:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/568603002/40001

[commit-bot: I haz the power, 2014-09-12 22:34:17]

Committed patchset #2 (id:40001) as e8391bac658bd4b6d9c9ce68988bedfaae9d0bce

[commit-bot: I haz the power, 2014-09-12 22:44:44]

Patchset 2 (id:??) landed as
https://crrev.com/37fa0e5170b4ae065c2aaced04516600e25bcd2e
Cr-Commit-Position: refs/heads/master@{#294682}