Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2737)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java

Issue 568603002: Upstream changes for android signin promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: todo added for experiment params Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/signin/signin_promo.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
index 583eeb38b6dd5bd94e1b023a1db4ea174c9cf5e7..91c149c0d5d0bbed14b443198977a690a1230f9a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
@@ -16,6 +16,7 @@ import android.util.Log;
import org.chromium.base.ActivityState;
import org.chromium.base.ApplicationStatus;
import org.chromium.base.CalledByNative;
+import org.chromium.base.FieldTrialList;
import org.chromium.base.ObserverList;
import org.chromium.base.ThreadUtils;
import org.chromium.chrome.R;
@@ -400,6 +401,22 @@ public class SigninManager {
return nativeIsNewProfileManagementEnabled();
}
+ /**
+ * @return Experiment group for the android signin promo that the current user falls into.
+ * -1 if the sigin promo experiment is disabled, otherwise an integer between 0 and 7.
+ * TODO(guohui): instead of group names, it is better to use experiment params to control
+ * the variations.
+ */
+ public static int getAndroidSigninPromoExperimentGroup() {
+ String fieldTrialValue =
+ FieldTrialList.findFullName("AndroidSigninPromo");
+ try {
+ return Integer.parseInt(fieldTrialValue);
+ } catch (NumberFormatException ex) {
+ return -1;
+ }
+ }
+
@CalledByNative
private void onSigninAllowedByPolicyChanged(boolean newSigninAllowedByPolicy) {
mSigninAllowedByPolicy = newSigninAllowedByPolicy;
« no previous file with comments | « no previous file | chrome/browser/signin/signin_promo.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698