Introduce WebRequestEventRouterDelegate.

extensions/browser/api/web_request/web_request_api_helpers.h

Index: extensions/browser/api/web_request/web_request_api_helpers.h
diff --git a/extensions/browser/api/web_request/web_request_api_helpers.h b/extensions/browser/api/web_request/web_request_api_helpers.h
index 77129466b93a7a6a2d13564c43ab5db1c595b431..2dba793a3d45a952498c813ffffca4f7bf8297a6 100644
--- a/extensions/browser/api/web_request/web_request_api_helpers.h
+++ b/extensions/browser/api/web_request/web_request_api_helpers.h
@@ -41,6 +41,8 @@ class URLRequest;
 
 namespace extension_web_request_api_helpers {
 
+#define ARRAYEND(array) (array + arraysize(array))

[Ken Rockot(use gerrit already), 2014/09/19 20:52:27]

Please don't define a macro like this in a header. Better to duplicate in
multiple cc files if you really need it in multiple places.

But I don't think this macro is really a good idea anyway. It is a much more
common convention in chrome code to do something like

const char* kSomeConstArray[] = {
  "foo",
  "bar",
  ...
};

const size_t kSomeConstArrayLength = arraysize(kSomeConstArray);

And then to explicitly use the right length constant wherever it's needed.

But at the very least if you want to keep using a macro, please don't define it
in a header.

[Xi Han, 2014/09/19 22:05:55]

Removed the macro.



On 2014/09/19 20:52:27, Ken Rockot wrote:

+
 typedef std::pair<std::string, std::string> ResponseHeader;
 typedef std::vector<ResponseHeader> ResponseHeaders;
 
@@ -320,6 +322,11 @@ void NotifyWebRequestAPIUsed(
 // extensions are installed.
 void SendExtensionWebRequestStatusToHost(content::RenderProcessHost* host);
 
+// Converts the |name|, |value| pair of a http header to a HttpHeaders
+// dictionary. Ownership is passed to the caller.
+base::DictionaryValue* ToHeaderDictionary(
+    const std::string& name, const std::string& value);
+
 }  // namespace extension_web_request_api_helpers
 
 #endif  // EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_API_HELPERS_H_