Introduce WebRequestEventRouterDelegate.

extensions/browser/api/web_request/web_request_api_helpers.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Helper classes and functions used for the WebRequest API.
 
 #ifndef EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_API_HELPERS_H_
 #define EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_API_HELPERS_H_
 
 #include <list>
@@ skipping 23 matching lines @@
 class Extension;
 }
 
 namespace net {
 class BoundNetLog;
 class URLRequest;
 }
 
 namespace extension_web_request_api_helpers {
 
+#define ARRAYEND(array) (array + arraysize(array))

[Ken Rockot(use gerrit already), 2014/09/19 20:52:27]

Please don't define a macro like this in a header. Better to duplicate in
multiple cc files if you really need it in multiple places.

But I don't think this macro is really a good idea anyway. It is a much more
common convention in chrome code to do something like

const char* kSomeConstArray[] = {
  "foo",
  "bar",
  ...
};

const size_t kSomeConstArrayLength = arraysize(kSomeConstArray);

And then to explicitly use the right length constant wherever it's needed.

But at the very least if you want to keep using a macro, please don't define it
in a header.

[Xi Han, 2014/09/19 22:05:55]

Removed the macro.



On 2014/09/19 20:52:27, Ken Rockot wrote:

+
 typedef std::pair<std::string, std::string> ResponseHeader;
 typedef std::vector<ResponseHeader> ResponseHeaders;
 
 // Data container for RequestCookies as defined in the declarative WebRequest
 // API definition.
 struct RequestCookie {
   RequestCookie();
   ~RequestCookie();
   scoped_ptr<std::string> name;
   scoped_ptr<std::string> value;
@@ skipping 259 matching lines @@
 // collect UMA statistics on Page Load Times. Needs to be called on the UI
 // thread.
 void NotifyWebRequestAPIUsed(
     void* browser_context_id,
     scoped_refptr<const extensions::Extension> extension);
 
 // Send updates to |host| with information about what webRequest-related
 // extensions are installed.
 void SendExtensionWebRequestStatusToHost(content::RenderProcessHost* host);
 
+// Converts the |name|, |value| pair of a http header to a HttpHeaders
+// dictionary. Ownership is passed to the caller.
+base::DictionaryValue* ToHeaderDictionary(
+    const std::string& name, const std::string& value);
+
 }  // namespace extension_web_request_api_helpers
 
 #endif  // EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_API_HELPERS_H_