Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: extensions/browser/api/web_request/web_request_api_helpers.cc

Issue 568583002: Introduce WebRequestEventRouterDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_api_helpers.cc
diff --git a/extensions/browser/api/web_request/web_request_api_helpers.cc b/extensions/browser/api/web_request/web_request_api_helpers.cc
index 29de9b6953e037cddb4932061fa54f1ae5b65a0b..a4d14f3768de15927f916b684abb81e83a4746d4 100644
--- a/extensions/browser/api/web_request/web_request_api_helpers.cc
+++ b/extensions/browser/api/web_request/web_request_api_helpers.cc
@@ -15,6 +15,7 @@
#include "components/web_cache/browser/web_cache_manager.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_process_host.h"
+#include "extensions/browser/api/web_request/web_request_api_constants.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/extensions_browser_client.h"
@@ -35,6 +36,8 @@ using base::Time;
using net::cookie_util::ParsedRequestCookie;
using net::cookie_util::ParsedRequestCookies;
+namespace keys = extension_web_request_api_constants;
+
namespace extension_web_request_api_helpers {
namespace {
@@ -1199,4 +1202,19 @@ void SendExtensionWebRequestStatusToHost(content::RenderProcessHost* host) {
host->Send(new ExtensionMsg_UsingWebRequestAPI(webrequest_used));
}
+// Converts the |name|, |value| pair of a http header to a HttpHeaders
+// dictionary. Ownership is passed to the caller.
+base::DictionaryValue* ToHeaderDictionary(const std::string& name,
Ken Rockot(use gerrit already) 2014/09/19 20:52:27 How about CreateHeaderDictionary or MakeHeaderDict
Xi Han 2014/09/19 22:05:55 Change to CreateHeaderDictionary.
+ const std::string& value) {
+ base::DictionaryValue* header = new base::DictionaryValue();
+ header->SetString(keys::kHeaderNameKey, name);
+ if (base::IsStringUTF8(value)) {
+ header->SetString(keys::kHeaderValueKey, value);
+ } else {
+ header->Set(keys::kHeaderBinaryValueKey,
+ StringToCharList(value));
+ }
+ return header;
+}
+
} // namespace extension_web_request_api_helpers

Powered by Google App Engine
This is Rietveld 408576698