Issue 568583002: Introduce WebRequestEventRouterDelegate.

Issue 568583002: Introduce WebRequestEventRouterDelegate. (Closed)

Created:
6 years, 3 months ago by Xi Han

Modified:
6 years, 3 months ago

Reviewers:
Fady Samuel, sky, Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, wjmaclean, lfg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Introduce WebRequestEventRouterDelegate to resolve the dependency of chrome in web_request_api.cc(.h). BUG=352293 Committed: https://crrev.com/4ac694a0db2d853a47ad8f213aae6fb303c5e6a8 Cr-Commit-Position: refs/heads/master@{#296010}

Patch Set 1 #

Patch Set 2 : Rename the delegate to WebRequestEventRouterDelegate. #

Total comments: 54

Patch Set 3 : Rebase rename. #

Patch Set 4 : Hide tab_id and window_id from extensions. #

Total comments: 2

Patch Set 5 : move tab_id and window_id back. #

Total comments: 2

Patch Set 6 : Small changes are made. #

Patch Set 7 : Fix gn build failure. #

Patch Set 8 : rebase. #

Total comments: 25

Patch Set 9 : changes are made. #

Total comments: 8

Patch Set 10 : changes are made. #

Total comments: 4

Patch Set 11 : nits #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+710 lines, -428 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/DEPS	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/chrome_extensions_api_client.h	View	1 2 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/chrome_extensions_api_client.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+6 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+41 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+234 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/web_request/web_request_api.h	View	1 2 3 4 5 6 7 8 9	19 chunks	+66 lines, -53 lines	0 comments	Download
M	chrome/browser/extensions/api/web_request/web_request_api.cc	View	1 2 3 4 5 6 7 8 9	75 chunks	+217 lines, -364 lines	0 comments	Download
M	chrome/browser/profiles/off_the_record_profile_impl.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2 3 4 5 6 7 8 9	1 chunk	+2 lines, -0 lines	0 comments	Download
M	extensions/browser/BUILD.gn	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download
M	extensions/browser/api/extensions_api_client.h	View	1 2 4	2 chunks	+5 lines, -0 lines	0 comments	Download
M	extensions/browser/api/extensions_api_client.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+5 lines, -0 lines	0 comments	Download
M	extensions/browser/api/web_request/web_request_api_helpers.h	View	1 2 3 4 5 6 7 8	2 chunks	+6 lines, -0 lines	0 comments	Download
M	extensions/browser/api/web_request/web_request_api_helpers.cc	View	1 2 3 4 5 6 7 8 9	3 chunks	+18 lines, -0 lines	0 comments	Download
M	extensions/browser/api/web_request/web_request_api_utils.cc	View	1 2 3 4 5 6 7 8	3 chunks	+16 lines, -6 lines	0 comments	Download
A	extensions/browser/api/web_request/web_request_event_router_delegate.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+58 lines, -0 lines	0 comments	Download
A	extensions/browser/api/web_request/web_request_event_router_delegate.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+20 lines, -0 lines	0 comments	Download
M	extensions/extensions.gyp	View	1 2 3 4 5 6 7 8 9	1 chunk	+6 lines, -0 lines	0 comments	Download
M	extensions/extensions_strings.grd	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 26 (8 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Fady Samuel

An initial set of comments. Mostly nits but a few open questions. https://codereview.chromium.org/568583002/diff/20001/chrome/browser/extensions/api/web_request/web_request_api.cc File chrome/browser/extensions/api/web_request/web_request_api.cc ...

6 years, 3 months ago (2014-09-12 21:55:41 UTC) #3

Xi Han

Please take another look. https://codereview.chromium.org/568583002/diff/20001/chrome/browser/extensions/api/web_request/web_request_api.cc File chrome/browser/extensions/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/568583002/diff/20001/chrome/browser/extensions/api/web_request/web_request_api.cc#newcode289 chrome/browser/extensions/api/web_request/web_request_api.cc:289: void* profile_id, On 2014/09/12 21:55:39, ...

6 years, 3 months ago (2014-09-18 16:24:02 UTC) #6

Fady Samuel

https://codereview.chromium.org/568583002/diff/120001/chrome/browser/extensions/api/web_request/web_request_api.cc File chrome/browser/extensions/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/568583002/diff/120001/chrome/browser/extensions/api/web_request/web_request_api.cc#newcode578 chrome/browser/extensions/api/web_request/web_request_api.cc:578: } else if (it.key() == "extraRequestParams") { Pass to ...

6 years, 3 months ago (2014-09-18 16:34:44 UTC) #8

Xi Han

Fady: as discussed offline, we will adopt the temporary solution to leave the tab_id and ...

6 years, 3 months ago (2014-09-18 21:57:48 UTC) #10

Fady Samuel

lgtm with nit. https://codereview.chromium.org/568583002/diff/160001/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc File chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc (right): https://codereview.chromium.org/568583002/diff/160001/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc#newcode226 chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc:226: (filter_window_id != -1 && window_id != ...

6 years, 3 months ago (2014-09-18 22:04:31 UTC) #11

Xi Han

+rockot@chromium.org: Please review all changes. Thanks! https://codereview.chromium.org/568583002/diff/160001/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc File chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc (right): https://codereview.chromium.org/568583002/diff/160001/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc#newcode226 chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc:226: (filter_window_id != -1 ...

6 years, 3 months ago (2014-09-18 22:19:21 UTC) #13

Ken Rockot(use gerrit already)

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensions/api/chrome_extensions_api_client.cc File chrome/browser/extensions/api/chrome_extensions_api_client.cc (right): https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensions/api/chrome_extensions_api_client.cc#newcode85 chrome/browser/extensions/api/chrome_extensions_api_client.cc:85: WebRequestEventRouterDelegate* ChromeExtensionsAPIClient:: nit: Style guide insists that in cases ...

6 years, 3 months ago (2014-09-19 20:52:28 UTC) #14

Fady Samuel

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/web_request/web_request_event_router_delegate.h File extensions/browser/api/web_request/web_request_event_router_delegate.h (right): https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/web_request/web_request_event_router_delegate.h#newcode45 extensions/browser/api/web_request/web_request_event_router_delegate.h:45: void* profile_id, On 2014/09/19 20:52:28, Ken Rockot wrote: > ...

6 years, 3 months ago (2014-09-19 20:56:26 UTC) #15

Xi Han

6 years, 3 months ago (2014-09-19 22:05:56 UTC) #16

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensio...
File chrome/browser/extensions/api/chrome_extensions_api_client.cc (right):

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensio...
chrome/browser/extensions/api/chrome_extensions_api_client.cc:85:
WebRequestEventRouterDelegate* ChromeExtensionsAPIClient::
Thanks Ken, I looked for style for this case but didn't find it. I try to avoid
using git cl format, since it adds lots of unnecessary changes for the files
being touched:(.

Updated.

On 2014/09/19 20:52:27, Ken Rockot wrote:
> nit: Style guide insists that in cases like this, the return type gets its own
> line and the method name is not indented. So:
> 
> WebRequestEventRouterDelegate*
> ChromeExtensionsAPIClient::CreateWebRequestEventRouterDelegate() const {
> 
> Would be the correct format.
> 
> If you run 'git cl format' before upload, it will probably do this kind of
stuff
> for you.

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensio...
File chrome/browser/extensions/api/web_request/DEPS (right):

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensio...
chrome/browser/extensions/api/web_request/DEPS:2:
"+extensions/strings/grit/extensions_strings.h",
On 2014/09/19 20:52:27, Ken Rockot wrote:
> I think you should actually just add this line to
chrome/browser/extensions/DEPS
> if you want.

Done.

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensio...
File
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h
(right):

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensio...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h:18:
// WebRequestEventRouterDelegate implementations:
On 2014/09/19 20:52:27, Ken Rockot wrote:
> nit: "implementation."

Done.

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
File extensions/browser/api/extensions_api_client.cc (right):

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
extensions/browser/api/extensions_api_client.cc:65:
WebRequestEventRouterDelegate* ExtensionsAPIClient::
On 2014/09/19 20:52:27, Ken Rockot wrote:
> Same deal with formatting here.

Done.

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_api_helpers.cc (right):

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_api_helpers.cc:1207:
base::DictionaryValue* ToHeaderDictionary(const std::string& name,
On 2014/09/19 20:52:27, Ken Rockot wrote:
> How about CreateHeaderDictionary or MakeHeaderDictionary? "To" prefixes
usually
> imply type conversion and this isn't quite type conversion.

Change to CreateHeaderDictionary.

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_api_helpers.h (right):

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_api_helpers.h:44: #define
ARRAYEND(array) (array + arraysize(array))
Removed the macro.

On 2014/09/19 20:52:27, Ken Rockot wrote:
> Please don't define a macro like this in a header. Better to duplicate in
> multiple cc files if you really need it in multiple places.
> 
> But I don't think this macro is really a good idea anyway. It is a much more
> common convention in chrome code to do something like
> 
> const char* kSomeConstArray[] = {
>   "foo",
>   "bar",
>   ...
> };
> 
> const size_t kSomeConstArrayLength = arraysize(kSomeConstArray);
> 
> And then to explicitly use the right length constant wherever it's needed.
> 
> But at the very least if you want to keep using a macro, please don't define
it
> in a header.

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_event_router_delegate.h
(right):

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_event_router_delegate.h:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
On 2014/09/19 20:52:27, Ken Rockot wrote:
> New files should use new copyright notice style (no "(c)", just "Copyright
2014
> ...")

Done.

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_event_router_delegate.h:11:
#include "url/gurl.h"
On 2014/09/19 20:52:27, Ken Rockot wrote:
> you can just forward-declare GURL instead of including this here
> 
> Actually you can forward-declare base::DictionaryValue as well.

Done.

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_event_router_delegate.h:14: class
ResourceRequestInfo;
On 2014/09/19 20:52:27, Ken Rockot wrote:
> not used

Removed.

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_event_router_delegate.h:15: }  //
namespace content
On 2014/09/19 20:52:28, Ken Rockot wrote:
> FYI I don't think it's necessary to include closing namespace comments for
small
> forward declaration blocks like this, but I guess it doesn't hurt.

I agree:)

https://codereview.chromium.org/568583002/diff/220001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_event_router_delegate.h:45: void*
profile_id,
On 2014/09/19 20:52:28, Ken Rockot wrote:
> Could you change this to browser_context_id? And actually can you remind me
why
> we're using a void* instead of just using a BrowserContext*?

Done.

Ken Rockot(use gerrit already)

6 years, 3 months ago (2014-09-19 23:08:34 UTC) #17

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensio...
File chrome/browser/extensions/api/chrome_extensions_api_client.cc (right):

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensio...
chrome/browser/extensions/api/chrome_extensions_api_client.cc:85:
WebRequestEventRouterDelegate* ChromeExtensionsAPIClient::
On 2014/09/19 22:05:55, hanxi wrote:
> Thanks Ken, I looked for style for this case but didn't find it. I try to
avoid
> using git cl format, since it adds lots of unnecessary changes for the files
> being touched:(.
> 
> Updated.
> 
> 
> On 2014/09/19 20:52:27, Ken Rockot wrote:
> > nit: Style guide insists that in cases like this, the return type gets its
own
> > line and the method name is not indented. So:
> > 
> > WebRequestEventRouterDelegate*
> > ChromeExtensionsAPIClient::CreateWebRequestEventRouterDelegate() const {
> > 
> > Would be the correct format.
> > 
> > If you run 'git cl format' before upload, it will probably do this kind of
> stuff
> > for you.
> 

OK, that's fair. In general we would prefer to see all code adhere to the style
guides set by the formatting tool so there's no ambiguity. It does add extra
noise for code reviews, but IMO it's fine. Please don't hesitate to apply
auto-formatting when sending code reviews my way, I'm used to the noise. :)

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
File chrome/browser/extensions/api/chrome_extensions_api_client.cc (right):

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
chrome/browser/extensions/api/chrome_extensions_api_client.cc:86:
ChromeExtensionsAPIClient::CreateWebRequestEventRouterDelegate() const {
This line should not be indented.

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
File
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc
(right):

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc:219:
bool ChromeExtensionWebRequestEventRouterDelegate::
Formatting here as well.

bool on its own line

ChromeExtensionWebRequestEventRouterDelegate::OnGetMatchingListenersImplCheck(

on its own line with no indent.

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
File
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h
(right):

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h:33:
void* profile_id,
Could you change the name to browser_context_id here as well?

Also I'm still wondering why we are using void* browser_context_id instead of
BrowserContext* browser_context. Is it because of some threading policy?

https://codereview.chromium.org/568583002/diff/240001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_event_router_delegate.h
(right):

https://codereview.chromium.org/568583002/diff/240001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_event_router_delegate.h:41:
virtual bool OnGetMachingListernersImplCheck(
Sorry I missed this the first time, but this has a few spelling errors. Should
be:

OnGetMatchingListenersImplCheck

Missing 't' in "matching" and you have an extra "r" in "listeners"

Xi Han

6 years, 3 months ago (2014-09-22 14:34:15 UTC) #18

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensio...
File chrome/browser/extensions/api/chrome_extensions_api_client.cc (right):

https://codereview.chromium.org/568583002/diff/220001/chrome/browser/extensio...
chrome/browser/extensions/api/chrome_extensions_api_client.cc:85:
WebRequestEventRouterDelegate* ChromeExtensionsAPIClient::
Glad to know:)

On 2014/09/19 23:08:33, Ken Rockot wrote:
> On 2014/09/19 22:05:55, hanxi wrote:
> > Thanks Ken, I looked for style for this case but didn't find it. I try to
> avoid
> > using git cl format, since it adds lots of unnecessary changes for the files
> > being touched:(.
> > 
> > Updated.
> > 
> > 
> > On 2014/09/19 20:52:27, Ken Rockot wrote:
> > > nit: Style guide insists that in cases like this, the return type gets its
> own
> > > line and the method name is not indented. So:
> > > 
> > > WebRequestEventRouterDelegate*
> > > ChromeExtensionsAPIClient::CreateWebRequestEventRouterDelegate() const {
> > > 
> > > Would be the correct format.
> > > 
> > > If you run 'git cl format' before upload, it will probably do this kind of
> > stuff
> > > for you.
> > 
> 
> OK, that's fair. In general we would prefer to see all code adhere to the
style
> guides set by the formatting tool so there's no ambiguity. It does add extra
> noise for code reviews, but IMO it's fine. Please don't hesitate to apply
> auto-formatting when sending code reviews my way, I'm used to the noise. :)

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
File chrome/browser/extensions/api/chrome_extensions_api_client.cc (right):

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
chrome/browser/extensions/api/chrome_extensions_api_client.cc:86:
ChromeExtensionsAPIClient::CreateWebRequestEventRouterDelegate() const {
On 2014/09/19 23:08:34, Ken Rockot wrote:
> This line should not be indented.

Done.

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
File
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc
(right):

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc:219:
bool ChromeExtensionWebRequestEventRouterDelegate::
On 2014/09/19 23:08:34, Ken Rockot wrote:
> Formatting here as well.
> 
> bool on its own line
> 
> ChromeExtensionWebRequestEventRouterDelegate::OnGetMatchingListenersImplCheck(
> 
> on its own line with no indent.

Done.

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
File
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h
(right):

https://codereview.chromium.org/568583002/diff/240001/chrome/browser/extensio...
chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h:33:
void* profile_id,
I talked with Battre@ about this, and he said void* was used to avoid
accidentally access profile on IO thread, but we could cast the pointer to a
BrowserContext* if we were certain to be on the UI thread. I look at the
implementation of this function again, and find out this function is not only
visited on UI thread. So I believe we'd better to use void* here.

On 2014/09/19 23:08:34, Ken Rockot wrote:
> Could you change the name to browser_context_id here as well?
> 
> Also I'm still wondering why we are using void* browser_context_id instead of
> BrowserContext* browser_context. Is it because of some threading policy?

https://codereview.chromium.org/568583002/diff/240001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_event_router_delegate.h
(right):

https://codereview.chromium.org/568583002/diff/240001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_event_router_delegate.h:41:
virtual bool OnGetMachingListernersImplCheck(
Sorry for the misspellings, corrected them.

On 2014/09/19 23:08:34, Ken Rockot wrote:
> Sorry I missed this the first time, but this has a few spelling errors. Should
> be:
> 
> OnGetMatchingListenersImplCheck
> 
> Missing 't' in "matching" and you have an extra "r" in "listeners"

Ken Rockot(use gerrit already)

Great, thanks! LGTM with a few small nits https://codereview.chromium.org/568583002/diff/260001/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc File chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc (right): https://codereview.chromium.org/568583002/diff/260001/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc#newcode26 chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc:26: // ...

6 years, 3 months ago (2014-09-22 14:37:25 UTC) #19

Xi Han

sky@chromium.org: Please review changes in -chrome/browser/profiles/off_the_record_profile_impl.cc Thanks! https://codereview.chromium.org/568583002/diff/260001/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc File chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc (right): https://codereview.chromium.org/568583002/diff/260001/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc#newcode26 chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc:26: // Convert ...

6 years, 3 months ago (2014-09-22 15:19:34 UTC) #21

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/568583002/280001

6 years, 3 months ago (2014-09-22 17:03:50 UTC) #24

commit-bot: I haz the power

Committed patchset #11 (id:280001) as 80399402e3491832a7718746849b0485fa8eecc4

6 years, 3 months ago (2014-09-22 17:54:53 UTC) #25

commit-bot: I haz the power

6 years, 3 months ago (2014-09-22 17:55:32 UTC) #26

Message was sent while issue was closed.

Patchset 11 (id:??) landed as
https://crrev.com/4ac694a0db2d853a47ad8f213aae6fb303c5e6a8
Cr-Commit-Position: refs/heads/master@{#296010}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages