Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 568363003: Speculative Layout Test fix for inspector/sources/debugger/promise-tracker.html (Closed)

Created:
6 years, 3 months ago by aandrey
Modified:
6 years, 3 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Speculative Layout Test fix for inspector/sources/debugger/promise-tracker.html BUG=414163 TBR=loislo, amikhaylova@google.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M LayoutTests/inspector/sources/debugger/promise-tracker.html View 4 chunks +11 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aandrey
6 years, 3 months ago (2014-09-15 08:36:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568363003/1
6 years, 3 months ago (2014-09-15 08:37:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181968
6 years, 3 months ago (2014-09-15 09:43:17 UTC) #4
sof
Giving back an error reason might be separately useful, but this doesn't address this Oilpan-specific ...
6 years, 3 months ago (2014-09-15 12:31:23 UTC) #6
aandrey
6 years, 3 months ago (2014-09-15 12:40:31 UTC) #7
Message was sent while issue was closed.
On 2014/09/15 12:31:23, sof wrote:
> Giving back an error reason might be separately useful, but this doesn't
address
> this Oilpan-specific gc-on-shutdown bug. See
> https://codereview.chromium.org/571043002/ for that.

Agreed. Thanks for looking into this!

Powered by Google App Engine
This is Rietveld 408576698