Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: LayoutTests/inspector/sources/debugger/promise-tracker.html

Issue 568363003: Speculative Layout Test fix for inspector/sources/debugger/promise-tracker.html (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/sources/debugger/promise-tracker.html
diff --git a/LayoutTests/inspector/sources/debugger/promise-tracker.html b/LayoutTests/inspector/sources/debugger/promise-tracker.html
index c724ecfa7717dd66cce6cdce0cbdd15d59026a19..d4c4376592581df1999a5ee472777a4dc3903d94 100644
--- a/LayoutTests/inspector/sources/debugger/promise-tracker.html
+++ b/LayoutTests/inspector/sources/debugger/promise-tracker.html
@@ -25,8 +25,6 @@ function errorCallback() { }
var test = function ()
{
- var output = [];
-
InspectorTest.startDebuggerTest(step1);
function step1()
@@ -42,6 +40,8 @@ var test = function ()
function didGetPromises(error, response)
{
+ InspectorTest.assertTrue(!error, "FAIL: " + error);
+
function comparePromiseData(x, y)
{
if (x.id < y.id)
@@ -59,6 +59,8 @@ var test = function ()
minPromiseId = Math.min(minPromiseId, response[i].id);
}
response.sort(comparePromiseData);
+
+ var output = [];
for (var i = 0; i < response.length; i++) {
var promise = response[i];
var parentId = promise.parentId ? promise.parentId - minPromiseId : undefined;
@@ -74,6 +76,13 @@ var test = function ()
InspectorTest.addResults(output);
DebuggerAgent.disablePromiseTracker();
+ DebuggerAgent.getPromises(didGetPromises2);
+ }
+
+ function didGetPromises2(error, response)
+ {
+ var hasData = !error && response && response.length > 0;
+ InspectorTest.assertTrue(!hasData, "FAIL: expected error or no data after disabling promise tracker.");
InspectorTest.completeDebuggerTest();
}
}
« no previous file with comments | « no previous file | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698