Issue 5682013: Add more FDE sorting to fix unwind_trace_test (x86-64 PIC)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5682013: Add more FDE sorting to fix unwind_trace_test (x86-64 PIC) (Closed)

Created:
10 years ago by jvoung - send to chromium...

Modified:
9 years, 7 months ago

Reviewers:
robertm, pdox

Visibility:
Public.

Description

The x86-64 PIC version of unwind_trace.cc seems to trigger a case where FDEs are not fully sorted before _Unwind_Find_FDE and search_object does a binary search over them. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1106

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	llvm-gcc-4.2/gcc/unwind-dw2-fde.c	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

robertm

10 years ago (2010-12-14 22:04:18 UTC) #2

LGTM

http://codereview.chromium.org/5682013/diff/1/llvm-gcc-4.2/gcc/unwind-dw2-fde.c
File llvm-gcc-4.2/gcc/unwind-dw2-fde.c (right):

http://codereview.chromium.org/5682013/diff/1/llvm-gcc-4.2/gcc/unwind-dw2-fde...
llvm-gcc-4.2/gcc/unwind-dw2-fde.c:592: // Sorting just the erratic and then
merging with the linear,
can you reference the bug from here as well

Expand Messages | Collapse Messages