Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: llvm-gcc-4.2/gcc/unwind-dw2-fde.c

Issue 5682013: Add more FDE sorting to fix unwind_trace_test (x86-64 PIC) (Closed)
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: llvm-gcc-4.2/gcc/unwind-dw2-fde.c
===================================================================
--- a/llvm-gcc-4.2/gcc/unwind-dw2-fde.c
+++ b/llvm-gcc-4.2/gcc/unwind-dw2-fde.c
@@ -588,6 +588,11 @@
fde_split (ob, fde_compare, accu->linear, accu->erratic);
gcc_assert (accu->linear->count + accu->erratic->count == count);
frame_heapsort (ob, fde_compare, accu->erratic);
+ // @LOCALMOD-BEGIN
+ // Sorting just the erratic and then merging with the linear,
robertm 2010/12/14 22:04:18 can you reference the bug from here as well
+ // can still leave it unsorted sometimes. Sort the linear as well!
+ frame_heapsort (ob, fde_compare, accu->linear);
+ // @LOCALMOD-END
fde_merge (ob, fde_compare, accu->linear, accu->erratic);
free (accu->erratic);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698