Issue 568023002: Use the regular start incremental marking strategy in the idle notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 568023002: Use the regular start incremental marking strategy in the idle notification. (Closed)

Created:
6 years, 3 months ago by Hannes Payer (out of office)

Modified:
6 years, 3 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Use the regular start incremental marking strategy in the idle notification. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23976

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -11 lines)			Patch
M	src/heap/gc-idle-time-handler.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/heap/gc-idle-time-handler.cc	View	1 2 3 4	3 chunks	+9 lines, -2 lines	0 comments	Download
M	src/heap/gc-idle-time-handler-unittest.cc	View	1 2 3	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/heap/heap.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/heap/incremental-marking.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap/incremental-marking.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 6 (1 generated)

ulan

LGTM Please run cctest/test-api in debug and no-snap mode before landing. I remember seeing failures ...

6 years, 3 months ago (2014-09-15 07:49:38 UTC) #3

Hannes Payer (out of office)

Thanks for pointing these tests out. Please have another look, I brought back the scavenge ...

6 years, 3 months ago (2014-09-16 09:50:13 UTC) #4

Hannes Payer (out of office)

6 years, 3 months ago (2014-09-16 12:49:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as 23976 (presubmit successful).