Issue 5680005: Fix long line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5680005: Fix long line. (Closed)

Created:
10 years ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix long line. TBR=whesse@chromium.org, Committed: http://code.google.com/p/v8/source/detail?r=5971

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/full-codegen.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

10 years ago (2010-12-11 01:47:41 UTC) #2

LGTM.

http://codereview.chromium.org/5680005/diff/1/src/full-codegen.h
File src/full-codegen.h (right):

http://codereview.chromium.org/5680005/diff/1/src/full-codegen.h#newcode539
src/full-codegen.h:539: // Calling an IC stub with a patch site. Passing NULL
for patch_site
I would say:
// Emit code that calls an IC stub.
// patch_site is NULL to indicate no smi code and emit a nop after the branch.
// patch_site is non-NULL to point to the beginning of inlined smi code, and
encode an offset to allow patching there.

Expand Messages | Collapse Messages