Chromium Code Reviews
Help | Chromium Project | Sign in
(249)

Issue 5680005: Fix long line. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by fschneider
Modified:
2 years, 10 months ago
Reviewers:
William Hesse
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Lint Patch
M src/full-codegen.h View 1 chunk +1 line, -1 line 1 comment 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
fschneider
3 years, 4 months ago #1
William Hesse
3 years, 4 months ago #2
LGTM.

http://codereview.chromium.org/5680005/diff/1/src/full-codegen.h
File src/full-codegen.h (right):

http://codereview.chromium.org/5680005/diff/1/src/full-codegen.h#newcode539
src/full-codegen.h:539: // Calling an IC stub with a patch site. Passing NULL
for patch_site
I would say:
// Emit code that calls an IC stub.
// patch_site is NULL to indicate no smi code and emit a nop after the branch.
// patch_site is non-NULL to point to the beginning of inlined smi code, and
encode an offset to allow patching there.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6