Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(525)

Issue 5680005: Fix long line. (Closed)

Created:
7 years, 4 months ago by fschneider
Modified:
6 years, 10 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/full-codegen.h View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
fschneider
7 years, 4 months ago (2010-12-10 14:36:44 UTC) #1
William Hesse
7 years, 4 months ago (2010-12-11 01:47:41 UTC) #2
LGTM.

http://codereview.chromium.org/5680005/diff/1/src/full-codegen.h
File src/full-codegen.h (right):

http://codereview.chromium.org/5680005/diff/1/src/full-codegen.h#newcode539
src/full-codegen.h:539: // Calling an IC stub with a patch site. Passing NULL
for patch_site
I would say:
// Emit code that calls an IC stub.
// patch_site is NULL to indicate no smi code and emit a nop after the branch.
// patch_site is non-NULL to point to the beginning of inlined smi code, and
encode an offset to allow patching there.

Powered by Google App Engine
This is Rietveld 408576698