Refactoring the weak_ptr_factory order in src/content/child

Refactoring the weak_ptr_factory order in src/content/child

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/66f9d03f574d2aff47a9c878125e191234201882
Cr-Commit-Position: refs/heads/master@{#294566}

[MRV, 2014-09-12 05:31:04]

mohan.reddy@samsung.com changed reviewers:
+ avi@chromium.org, jam@chromium.org

[MRV, 2014-09-12 05:31:05]

avi@chromium.org: Please review changes in src/content/child

jam@chromium.org: Please review changes in src/content/child

PTAL

[Avi (use Gerrit), 2014-09-12 05:55:02]

It's pointless to assign two reviewers for the same code. You only need one of
us. This LGTM mod the comment.

https://codereview.chromium.org/567873003/diff/1/content/child/resource_dispa...
File content/child/resource_dispatcher.h (right):

https://codereview.chromium.org/567873003/diff/1/content/child/resource_dispa...
content/child/resource_dispatcher.h:221:
base::WeakPtrFactory<ResourceDispatcher> weak_factory_;
You don't need that explanatory comment. That's true for most weak pointers.

[MRV, 2014-09-12 06:06:15]

On 2014/09/12 05:55:02, Avi wrote:
> It's pointless to assign two reviewers for the same code. You only need one of
> us. This LGTM mod the comment.
> 
>
https://codereview.chromium.org/567873003/diff/1/content/child/resource_dispa...
> File content/child/resource_dispatcher.h (right):
> 
>
https://codereview.chromium.org/567873003/diff/1/content/child/resource_dispa...
> content/child/resource_dispatcher.h:221:
> base::WeakPtrFactory<ResourceDispatcher> weak_factory_;
> You don't need that explanatory comment. That's true for most weak pointers.

Dear Mr. Avi,
Thanks for LGTM, from next time I'll take care adding only one reviewer.

[MRV, 2014-09-12 06:06:32]

Done, thank you.

https://codereview.chromium.org/567873003/diff/1/content/child/resource_dispa...
File content/child/resource_dispatcher.h (right):

https://codereview.chromium.org/567873003/diff/1/content/child/resource_dispa...
content/child/resource_dispatcher.h:221:
base::WeakPtrFactory<ResourceDispatcher> weak_factory_;
On 2014/09/12 05:55:01, Avi wrote:
> You don't need that explanatory comment. That's true for most weak pointers.

Done.

[MRV, 2014-09-12 06:06:52]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-12 06:07:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/567873003/20001

[commit-bot: I haz the power, 2014-09-12 06:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 06:29:12]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[MRV, 2014-09-12 06:33:42]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-12 06:33:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/567873003/20001

[commit-bot: I haz the power, 2014-09-12 09:52:35]

Committed patchset #2 (id:20001) as 8846b461ae3edeaa5433f97807d1d7b00ffcf5a7

[commit-bot: I haz the power, 2014-09-12 09:58:59]

Patchset 2 (id:??) landed as
https://crrev.com/66f9d03f574d2aff47a9c878125e191234201882
Cr-Commit-Position: refs/heads/master@{#294566}