Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Side by Side Diff: content/child/threaded_data_provider.h

Issue 567873003: Refactoring the weak_ptr_factory order in src/content/child (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch as per comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/child/resource_dispatcher.cc ('k') | content/child/threaded_data_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_CHILD_THREADEDDATAPROVIDER_IMPL_H_ 5 #ifndef CONTENT_CHILD_THREADEDDATAPROVIDER_IMPL_H_
6 #define CONTENT_CHILD_THREADEDDATAPROVIDER_IMPL_H_ 6 #define CONTENT_CHILD_THREADEDDATAPROVIDER_IMPL_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/linked_ptr.h" 9 #include "base/memory/linked_ptr.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 void StopOnBackgroundThread(); 49 void StopOnBackgroundThread();
50 void OnResourceMessageFilterAddedBackgroundThread(); 50 void OnResourceMessageFilterAddedBackgroundThread();
51 void ForwardAndACKData(const char* data, int data_length); 51 void ForwardAndACKData(const char* data, int data_length);
52 52
53 scoped_refptr<IPC::MessageFilter> filter_; 53 scoped_refptr<IPC::MessageFilter> filter_;
54 int request_id_; 54 int request_id_;
55 linked_ptr<base::SharedMemory> shm_buffer_; 55 linked_ptr<base::SharedMemory> shm_buffer_;
56 int shm_size_; 56 int shm_size_;
57 scoped_ptr<base::WeakPtrFactory<ThreadedDataProvider> > 57 scoped_ptr<base::WeakPtrFactory<ThreadedDataProvider> >
58 background_thread_weak_factory_; 58 background_thread_weak_factory_;
59 base::WeakPtrFactory<ThreadedDataProvider>
60 main_thread_weak_factory_;
61 WebThreadImpl& background_thread_; 59 WebThreadImpl& background_thread_;
62 IPC::SyncChannel* ipc_channel_; 60 IPC::SyncChannel* ipc_channel_;
63 blink::WebThreadedDataReceiver* threaded_data_receiver_; 61 blink::WebThreadedDataReceiver* threaded_data_receiver_;
64 bool resource_filter_active_; 62 bool resource_filter_active_;
65 base::MessageLoop* main_thread_message_loop_; 63 base::MessageLoop* main_thread_message_loop_;
66 64
67 struct QueuedSharedMemoryData { 65 struct QueuedSharedMemoryData {
68 const char* data; 66 const char* data;
69 int length; 67 int length;
70 }; 68 };
71 std::vector<QueuedSharedMemoryData> queued_data_; 69 std::vector<QueuedSharedMemoryData> queued_data_;
72 70
71 base::WeakPtrFactory<ThreadedDataProvider>
72 main_thread_weak_factory_;
73
73 DISALLOW_COPY_AND_ASSIGN(ThreadedDataProvider); 74 DISALLOW_COPY_AND_ASSIGN(ThreadedDataProvider);
74 }; 75 };
75 76
76 } // namespace content 77 } // namespace content
77 78
78 #endif // CONTENT_CHILD_THREADEDDATAPROVIDER_IMPL_H_ 79 #endif // CONTENT_CHILD_THREADEDDATAPROVIDER_IMPL_H_
OLDNEW
« no previous file with comments | « content/child/resource_dispatcher.cc ('k') | content/child/threaded_data_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698