Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 567733002: Revert 282243 "Fix an issue that android Download Manager doesn'..." (Closed)

Created:
6 years, 3 months ago by qinmin
Modified:
6 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert 282243 "Fix an issue that android Download Manager doesn'..." > Fix an issue that android Download Manager doesn't handle OMA files correctly > > For OMA files, it looks like that android download manager cannot correctly download it. > Some of the files cannot be downloaded, and some of the files downloaded has different binary content as the ones downloaed on chrome desktop. > Bypass android download manager for OMA mime types. > > BUG=382698 > > Review URL: https://codereview.chromium.org/331143010 TBR=tedchoc@chromium.org BUG=382698 Committed: https://crrev.com/36ab8ba1abae1ab1d2059924969bf671797fa9d4 Cr-Commit-Position: refs/heads/master@{#294538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/android/intercept_download_resource_throttle.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567733002/1
6 years, 3 months ago (2014-09-11 18:09:36 UTC) #2
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-12 00:36:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567733002/1
6 years, 3 months ago (2014-09-12 03:43:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3777f485b98a3072e1cceed9d6ed6d53eb163f57
6 years, 3 months ago (2014-09-12 03:48:24 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 03:50:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36ab8ba1abae1ab1d2059924969bf671797fa9d4
Cr-Commit-Position: refs/heads/master@{#294538}

Powered by Google App Engine
This is Rietveld 408576698