Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 331143010: Fix an issue that android Download Manager doesn't handle OMA files correctly (Closed)

Created:
6 years, 6 months ago by qinmin
Modified:
6 years, 5 months ago
Reviewers:
Ted C, asanka
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix an issue that android Download Manager doesn't handle OMA files correctly For OMA files, it looks like that android download manager cannot correctly download it. Some of the files cannot be downloaded, and some of the files downloaded has different binary content as the ones downloaed on chrome desktop. Bypass android download manager for OMA mime types. BUG=382698 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282243

Patch Set 1 : #

Total comments: 2

Patch Set 2 : adding comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M chrome/browser/android/intercept_download_resource_throttle.cc View 1 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
qinmin
PTAL
6 years, 6 months ago (2014-06-17 00:48:40 UTC) #1
qinmin
PTAL
6 years, 6 months ago (2014-06-17 00:48:41 UTC) #2
asanka
lgtm I'm assuming that the MIME type comparison is sufficient for this. https://codereview.chromium.org/331143010/diff/20001/chrome/browser/android/intercept_download_resource_throttle.cc File chrome/browser/android/intercept_download_resource_throttle.cc ...
6 years, 6 months ago (2014-06-17 00:59:54 UTC) #3
qinmin
https://codereview.chromium.org/331143010/diff/20001/chrome/browser/android/intercept_download_resource_throttle.cc File chrome/browser/android/intercept_download_resource_throttle.cc (right): https://codereview.chromium.org/331143010/diff/20001/chrome/browser/android/intercept_download_resource_throttle.cc#newcode76 chrome/browser/android/intercept_download_resource_throttle.cc:76: if (!mime.compare(kOmaDrmContentMime) || !mime.compare(kOmaDrmMessageMime)) On 2014/06/17 00:59:54, asanka wrote: ...
6 years, 6 months ago (2014-06-17 01:13:56 UTC) #4
Ted C
lgtm
6 years, 6 months ago (2014-06-17 01:14:35 UTC) #5
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 5 months ago (2014-07-09 23:58:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/331143010/40001
6 years, 5 months ago (2014-07-10 00:00:26 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 03:46:39 UTC) #8
Message was sent while issue was closed.
Change committed as 282243

Powered by Google App Engine
This is Rietveld 408576698