Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 567553002: TPMTokenLoader: Report both the disabled and enabled state of the TPM. (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
stevenjb, tbarzic, mattm
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@nss_util_deadcode
Project:
chromium
Visibility:
Public.

Description

TPMTokenLoader: Report both the disabled and enabled state of the TPM. Also change from the observer pattern to the simpler callback pattern, as there is only a single notification type (TPM is enabled/disabled). This simplifies ownership of the observer/receiver especially if multiple threads (typically UI and IO) are involved: A temporary callback with a WeakPtr can be used instead of an observer object that has to be owned by someone. BUG=413219 Committed: https://crrev.com/a52b2d041ac1f2e2905b0b9e5d222cee5a9ff116 Cr-Commit-Position: refs/heads/master@{#294454}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -45 lines) Patch
M chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service.h View 4 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service.cc View 1 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/tpm_token_loader.h View 4 chunks +13 lines, -14 lines 0 comments Download
M chromeos/tpm_token_loader.cc View 4 chunks +27 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
pneubeck (no reviews)
Toni, please review this one. I separated this smaller part from the larger CL: https://codereview.chromium.org/419013003/ ...
6 years, 3 months ago (2014-09-11 13:24:55 UTC) #3
tbarzic
On 2014/09/11 13:24:55, pneubeck wrote: > Toni, please review this one. > I separated this ...
6 years, 3 months ago (2014-09-11 16:45:16 UTC) #4
pneubeck (no reviews)
Steven please owner review. Thanks!
6 years, 3 months ago (2014-09-11 18:03:15 UTC) #6
stevenjb
lgtm https://codereview.chromium.org/567553002/diff/20001/chrome/browser/chromeos/ownership/owner_settings_service.cc File chrome/browser/chromeos/ownership/owner_settings_service.cc (right): https://codereview.chromium.org/567553002/diff/20001/chrome/browser/chromeos/ownership/owner_settings_service.cc#newcode363 chrome/browser/chromeos/ownership/owner_settings_service.cc:363: void OwnerSettingsService::OnTPMTokenReady(bool token_enabled) { nit: (bool /* unused ...
6 years, 3 months ago (2014-09-11 18:16:55 UTC) #7
pneubeck (no reviews)
https://codereview.chromium.org/567553002/diff/20001/chrome/browser/chromeos/ownership/owner_settings_service.cc File chrome/browser/chromeos/ownership/owner_settings_service.cc (right): https://codereview.chromium.org/567553002/diff/20001/chrome/browser/chromeos/ownership/owner_settings_service.cc#newcode363 chrome/browser/chromeos/ownership/owner_settings_service.cc:363: void OwnerSettingsService::OnTPMTokenReady(bool token_enabled) { On 2014/09/11 18:16:55, stevenjb wrote: ...
6 years, 3 months ago (2014-09-11 18:49:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567553002/40001
6 years, 3 months ago (2014-09-11 18:55:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 79f5826fac2c5096b0004a6a8eb0f19ec74c0c8d
6 years, 3 months ago (2014-09-11 20:17:46 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 20:26:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a52b2d041ac1f2e2905b0b9e5d222cee5a9ff116
Cr-Commit-Position: refs/heads/master@{#294454}

Powered by Google App Engine
This is Rietveld 408576698