chrome/browser/chromeos/settings/device_settings_service_unittest.cc - Issue 567553002: TPMTokenLoader: Report both the disabled and enabled state of the TPM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/device_settings_service_unittest.cc

Issue 567553002: TPMTokenLoader: Report both the disabled and enabled state of the TPM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nss_util_deadcode

Patch Set: Addressed nit. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/ownership/owner_settings_service.cc ('k') | chrome/browser/chromeos/settings/device_settings_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/settings/device_settings_service_unittest.cc

diff --git a/chrome/browser/chromeos/settings/device_settings_service_unittest.cc b/chrome/browser/chromeos/settings/device_settings_service_unittest.cc

index 816995f0dfa635b69cb1cc1a60efce4db0fa53ea..4c293a545868680997c209211f5787f027f4efce 100644

--- a/chrome/browser/chromeos/settings/device_settings_service_unittest.cc

+++ b/chrome/browser/chromeos/settings/device_settings_service_unittest.cc

@@ -516,7 +516,7 @@ TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForNonOwner) {

device_settings_service_.GetOwnershipStatus());

EXPECT_FALSE(is_owner_set_);

- service->OnTPMTokenReady();

+ service->OnTPMTokenReady(true /* is ready */);

FlushDeviceSettings();

EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());

@@ -560,7 +560,7 @@ TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForOwner) {

EXPECT_FALSE(is_owner_set_);

owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey());

- service->OnTPMTokenReady();

+ service->OnTPMTokenReady(true /* is ready */);

FlushDeviceSettings();

EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey());