Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 567463002: Color picker window should not have a minimize button. (Closed)

Created:
6 years, 3 months ago by Gaja
Modified:
6 years, 3 months ago
Reviewers:
jackhou1, sadrul
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Color picker window should not have a minimize button. Adding CanMinimize() (like CanMaximize()) function to WidgetDelegate class. So that ColorChooserView or any other view inheriting WidgetDelegate, can decide whether its window can show minimize button. BUG=365768 R=sadrul@chromium.org TEST= 1. Go to a page with <input type=color>. Here is one http://jsbin.com/yotasure/1 2. Click on the color input button to bring up the color picker window and observe 3. Color picker window should not have minimize button. Committed: https://crrev.com/a0aab5b44df674946fbd6b5c170f433918bdb925 Cr-Commit-Position: refs/heads/master@{#295919}

Patch Set 1 #

Patch Set 2 : Rebased and Added unit test for minimize button visibility. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -14 lines) Patch
M ui/views/color_chooser/color_chooser_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/widget_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/widget_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/window/custom_frame_view.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/window/custom_frame_view_unittest.cc View 1 6 chunks +42 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (1 generated)
Gaja
@sadrul PTAL.
6 years, 3 months ago (2014-09-11 07:10:12 UTC) #1
Gaja
On 2014/09/11 07:10:12, Gajendra N wrote: > @sadrul > PTAL. @sadrul PTAL.
6 years, 3 months ago (2014-09-12 08:09:46 UTC) #2
Gaja
On 2014/09/12 08:09:46, Gajendra N wrote: > On 2014/09/11 07:10:12, Gajendra N wrote: > > ...
6 years, 3 months ago (2014-09-13 10:27:48 UTC) #3
Gaja
On 2014/09/13 10:27:48, Gajendra N wrote: > On 2014/09/12 08:09:46, Gajendra N wrote: > > ...
6 years, 3 months ago (2014-09-15 11:19:53 UTC) #4
sadrul
The change looks good. I have asked for confirmation whether we want this on all ...
6 years, 3 months ago (2014-09-15 14:43:53 UTC) #5
Gaja
On 2014/09/15 14:43:53, sadrul wrote: > The change looks good. I have asked for confirmation ...
6 years, 3 months ago (2014-09-16 03:49:41 UTC) #6
Gaja
On 2014/09/16 03:49:41, Gajendra N wrote: > On 2014/09/15 14:43:53, sadrul wrote: > > The ...
6 years, 3 months ago (2014-09-16 17:49:03 UTC) #7
Gaja
On 2014/09/16 17:49:03, Gajendra N wrote: > On 2014/09/16 03:49:41, Gajendra N wrote: > > ...
6 years, 3 months ago (2014-09-19 05:49:51 UTC) #8
sadrul
LGTM +jackhou@, since he is making the same change in WidgetDelegate at https://codereview.chromium.org/583603004/
6 years, 3 months ago (2014-09-22 00:35:22 UTC) #9
jackhou1
On 2014/09/22 00:35:22, sadrul wrote: > LGTM > > +jackhou@, since he is making the ...
6 years, 3 months ago (2014-09-22 01:46:57 UTC) #10
Gaja
On 2014/09/22 01:46:57, jackhou1 wrote: > On 2014/09/22 00:35:22, sadrul wrote: > > LGTM > ...
6 years, 3 months ago (2014-09-22 02:52:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/567463002/20001
6 years, 3 months ago (2014-09-22 02:53:46 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c392b3af1a94b78c3d569810363b6f970087363e
6 years, 3 months ago (2014-09-22 03:50:26 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 03:51:16 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0aab5b44df674946fbd6b5c170f433918bdb925
Cr-Commit-Position: refs/heads/master@{#295919}

Powered by Google App Engine
This is Rietveld 408576698