Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 567343002: Move setup of code event handlers to gin (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move setup of code event handlers to gin This will make sure that the handlers are set at the correct point during v8::Isolate construction BUG=none R=svenpanne@chromium.org Committed: https://crrev.com/4879fd2c9e48ddadd001fed382163c26586476ce Cr-Commit-Position: refs/heads/master@{#295066}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -7 lines) Patch
M chrome/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/profiling.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M gin/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A gin/debug_impl.h View 1 chunk +21 lines, -0 lines 0 comments Download
A gin/debug_impl.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M gin/gin.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M gin/isolate_holder.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
A gin/public/debug.h View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-15 10:03:27 UTC) #1
jochen (gone - plz use gerrit)
ptal depends on https://codereview.chromium.org/570993002
6 years, 3 months ago (2014-09-15 10:03:48 UTC) #2
Sven Panne
lgtm
6 years, 3 months ago (2014-09-15 10:45:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567343002/1
6 years, 3 months ago (2014-09-16 11:28:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/56472) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/15413) ios_rel_device ...
6 years, 3 months ago (2014-09-16 11:31:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567343002/20001
6 years, 3 months ago (2014-09-16 12:16:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4feb82160c71b17dc5142144df797d7d79fd348b
6 years, 3 months ago (2014-09-16 15:05:31 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 15:07:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4879fd2c9e48ddadd001fed382163c26586476ce
Cr-Commit-Position: refs/heads/master@{#295066}

Powered by Google App Engine
This is Rietveld 408576698