Introduce Isolate::CreateParams

Currently, a new isolate is created in an uninitialized state, and
several API methods will automatically initialize it. During this
uninitialized state, code event handlers and function entry handlers can
be attached to the isolate.

This CL deprecates SetFunctionEntryHook and moves the configuration of
those handlers to the Isolate factory method.

This will allow for initializing the Isolate at creation time in the
future.

Users of V8::SetFunctionEntryHook should pass the entry hook to
Isolate::New instead. V8::SetJitCodeEventHandler should either be passed
to Isolate::New as well, or (if startup events are not required) invoked
via the Isolate.

BUG=none
LOG=y
R=svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23940

[jochen (gone - plz use gerrit), 2014-09-15 09:29:03]

ptal

[Sven Panne, 2014-09-15 10:43:58]

https://codereview.chromium.org/570993002/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/570993002/diff/20001/include/v8.h#newcode4357
include/v8.h:4357: struct CreateParams {
Can we somehow indicate "Isolate" in the name? Just "CreateParams" looks a bit
too generic...

https://codereview.chromium.org/570993002/diff/20001/include/v8.h#newcode4485
include/v8.h:4485: static Isolate* New(CreateParams params = CreateParams());
Can we make this a const ref?

[jochen (gone - plz use gerrit), 2014-09-15 11:03:50]

https://codereview.chromium.org/570993002/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/570993002/diff/20001/include/v8.h#newcode4357
include/v8.h:4357: struct CreateParams {
On 2014/09/15 at 10:43:58, Sven Panne wrote:
> Can we somehow indicate "Isolate" in the name? Just "CreateParams" looks a bit
too generic...

the full name is v8::Isolate::CreateParams (in chrome we have e.g.
content::WebContents::CreateParams)

https://codereview.chromium.org/570993002/diff/20001/include/v8.h#newcode4485
include/v8.h:4485: static Isolate* New(CreateParams params = CreateParams());
On 2014/09/15 at 10:43:58, Sven Panne wrote:
> Can we make this a const ref?

done

[Sven Panne, 2014-09-15 11:14:23]

LGTM. Didn't see the nesting within Isolate... :-}

[jochen (gone - plz use gerrit), 2014-09-15 11:17:14]

Committed patchset #3 (id:40001) manually as 23940 (presubmit successful).