Chromecast Android shell improvements

Chromecast Android shell improvements:
* Handling RenderProcessGone in CastWindowAndroid
* Using CastBrowserProcess instead of passing the browser context
* A few style nits

R=byungchul@chromium.org,lcwu@chromium.org
BUG=None

Committed: https://crrev.com/98dd6bf5335d87832f551e839b799421e45b3a5e
Cr-Commit-Position: refs/heads/master@{#295210}

[byungchul, 2014-09-13 00:01:29]

lgtm

[lcwu1, 2014-09-16 22:46:51]

I am not sure we want to say "forward-porting ..." in the upstream commit
message. It probably does't mean much to the public. I would simply listed the
features/bug fixes in this CL. (It seems to me that the bug fix for renderer
crash issue is the main feature in this CL so you might want to list/mention it
first.)

https://codereview.chromium.org/566963003/diff/1/chromecast/shell/browser/and...
File chromecast/shell/browser/android/cast_window_android.h (right):

https://codereview.chromium.org/566963003/diff/1/chromecast/shell/browser/and...
chromecast/shell/browser/android/cast_window_android.h:53: //
content::WebContentsDelegate
I thought our convention is to use "content::WebContentsDelegate:". (Sorry that
I missed this when reviewing the internal CL.)

https://codereview.chromium.org/566963003/diff/1/chromecast/shell/browser/and...
chromecast/shell/browser/android/cast_window_android.h:70: //
content::WebContentsObserver
Ditto.

[gunsch, 2014-09-16 23:02:36]

https://codereview.chromium.org/566963003/diff/1/chromecast/shell/browser/and...
File chromecast/shell/browser/android/cast_window_android.h (right):

https://codereview.chromium.org/566963003/diff/1/chromecast/shell/browser/and...
chromecast/shell/browser/android/cast_window_android.h:53: //
content::WebContentsDelegate
On 2014/09/16 22:46:50, lcwu1 wrote:
> I thought our convention is to use "content::WebContentsDelegate:". (Sorry
that
> I missed this when reviewing the internal CL.)

Done.

https://codereview.chromium.org/566963003/diff/1/chromecast/shell/browser/and...
chromecast/shell/browser/android/cast_window_android.h:70: //
content::WebContentsObserver
On 2014/09/16 22:46:50, lcwu1 wrote:
> Ditto.

Done.

[lcwu1, 2014-09-16 23:26:06]

https://codereview.chromium.org/566963003/diff/1/chromecast/shell/browser/and...
File chromecast/shell/browser/android/cast_window_android.h (right):

https://codereview.chromium.org/566963003/diff/1/chromecast/shell/browser/and...
chromecast/shell/browser/android/cast_window_android.h:53: //
content::WebContentsDelegate
On 2014/09/16 23:02:36, gunsch wrote:
> On 2014/09/16 22:46:50, lcwu1 wrote:
> > I thought our convention is to use "content::WebContentsDelegate:". (Sorry
> that
> > I missed this when reviewing the internal CL.)
> 
> Done.

Sorry again. :-) I meant to say "content::WebContentsDelegate implementation:".
I missed the all important 'implementation'.

[lcwu1, 2014-09-16 23:27:59]

Also what I meant for the commit message is that I think it's good to mention a
CL is from upstream when porting to downstream, but it's not necessary to say
this is from downstream (or forward-porting) because upstream shouldn't care
about downstream. (Just my thoughts so you don't have to change if you don't
agree.)

[gunsch, 2014-09-17 00:10:12]

On 2014/09/16 23:26:06, lcwu1 wrote:
>
https://codereview.chromium.org/566963003/diff/1/chromecast/shell/browser/and...
> File chromecast/shell/browser/android/cast_window_android.h (right):
> 
>
https://codereview.chromium.org/566963003/diff/1/chromecast/shell/browser/and...
> chromecast/shell/browser/android/cast_window_android.h:53: //
> content::WebContentsDelegate
> On 2014/09/16 23:02:36, gunsch wrote:
> > On 2014/09/16 22:46:50, lcwu1 wrote:
> > > I thought our convention is to use "content::WebContentsDelegate:". (Sorry
> > that
> > > I missed this when reviewing the internal CL.)
> > 
> > Done.
> 
> Sorry again. :-) I meant to say "content::WebContentsDelegate
implementation:".
> I missed the all important 'implementation'.

I've been hearing a preference from Chromium folks lately for removing
"implementation". But I looked at the chromecast/ dir and it looks like we don't
have any instances of that; I think it's just been on the //components/metrics
code I've been shuffling around. Added "implementation" :)

[lcwu1, 2014-09-17 00:18:38]

lgtm

[gunsch, 2014-09-17 00:21:24]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-09-17 00:22:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566963003/40001

[commit-bot: I haz the power, 2014-09-17 01:36:54]

Committed patchset #3 (id:40001) as bbc318a3d0bd72944f5140adf98f2e4c277dd248

[commit-bot: I haz the power, 2014-09-17 01:37:31]

Patchset 3 (id:??) landed as
https://crrev.com/98dd6bf5335d87832f551e839b799421e45b3a5e
Cr-Commit-Position: refs/heads/master@{#295210}