Chromecast Android shell improvements

chromecast/shell/browser/android/cast_window_android.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMECAST_SHELL_BROWSER_ANDROID_CAST_WINDOW_ANDROID_H_
 #define CHROMECAST_SHELL_BROWSER_ANDROID_CAST_WINDOW_ANDROID_H_
 
 #include <jni.h>
 #include <vector>
 
@@ skipping 32 matching lines @@
       const GURL& url);
 
   virtual ~CastWindowAndroid();
 
   void LoadURL(const GURL& url);
   void Close();
 
   // Registers the JNI methods for CastWindowAndroid.
   static bool RegisterJni(JNIEnv* env);
 
-  // WebContentsDelegate implementation.
+  // content::WebContentsDelegate

[lcwu1, 2014/09/16 22:46:50]

I thought our convention is to use "content::WebContentsDelegate:". (Sorry that
I missed this when reviewing the internal CL.)

[gunsch, 2014/09/16 23:02:36]

Done.

[lcwu1, 2014/09/16 23:26:06]

Sorry again. :-) I meant to say "content::WebContentsDelegate implementation:".
I missed the all important 'implementation'.

   virtual void AddNewContents(content::WebContents* source,
                               content::WebContents* new_contents,
                               WindowOpenDisposition disposition,
                               const gfx::Rect& initial_pos,
                               bool user_gesture,
                               bool* was_blocked) OVERRIDE;
   virtual void CloseContents(content::WebContents* source) OVERRIDE;
   virtual bool CanOverscrollContent() const OVERRIDE;
   virtual bool AddMessageToConsole(content::WebContents* source,
                                    int32 level,
                                    const base::string16& message,
                                    int32 line_no,
                                    const base::string16& source_id) OVERRIDE;
   virtual void ActivateContents(content::WebContents* contents) OVERRIDE;
   virtual void DeactivateContents(content::WebContents* contents) OVERRIDE;
 
+  // content::WebContentsObserver

[lcwu1, 2014/09/16 22:46:50]

Ditto.

[gunsch, 2014/09/16 23:02:36]

Done.

+  virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE;
+
  private:
   explicit CastWindowAndroid(content::WebContents* web_contents);
 
   // Helper to create a new CastWindowAndroid given a newly created WebContents.
   static CastWindowAndroid* CreateCastWindowAndroid(
       content::WebContents* web_contents,
       const gfx::Size& initial_size);
 
   base::android::ScopedJavaGlobalRef<jobject> java_object_;
   scoped_ptr<content::WebContents> web_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(CastWindowAndroid);
 };
 
 }  // namespace shell
 }  // namespace chromecast
 
 #endif  // CHROMECAST_SHELL_BROWSER_ANDROID_CAST_WINDOW_ANDROID_H_