Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 566913002: Revert of HTMLSelectElement does not include selected index/indices while saving state (Closed)

Created:
6 years, 3 months ago by Michael van Ouwerkerk
Modified:
6 years, 3 months ago
Reviewers:
tkent, keishi, spartha
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of HTMLSelectElement does not include selected index/indices while saving state (patchset #8 id:160001 of https://codereview.chromium.org/541693003/) Reason for revert: Looks like this test crashes consistently on Android Tests (dbg) starting at this build: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/21459 Original issue's description: > HTMLSelectElement does not include selected index/indices while saving state > > Since index is not part of the FormControl state for select, there is no > way to restore it to proper index if there are duplicate values. This > patch includes the index in the FormControl state for select. > > BUG=401506 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181883 TBR=tkent@chromium.org,keishi@chromium.org,sudarshan.p@samsung.com NOTREECHECKS=true NOTRY=true BUG=401506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -132 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 2 chunks +11 lines, -25 lines 0 comments Download
D Source/core/html/HTMLSelectElementTest.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
M Source/core/html/forms/FormController.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael van Ouwerkerk
Created Revert of HTMLSelectElement does not include selected index/indices while saving state
6 years, 3 months ago (2014-09-12 15:31:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566913002/1
6 years, 3 months ago (2014-09-12 15:31:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181911
6 years, 3 months ago (2014-09-12 15:32:27 UTC) #3
spartha
On 2014/09/12 15:32:27, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 3 months ago (2014-09-23 14:09:44 UTC) #4
Michael van Ouwerkerk
6 years, 3 months ago (2014-09-23 14:18:27 UTC) #5
Message was sent while issue was closed.
On 2014/09/23 14:09:44, spartha wrote:
> On 2014/09/12 15:32:27, I haz the power (commit-bot) wrote:
> > Committed patchset #1 (id:1) as 181911
> 
> There is chromium patch that fixes the assertion failure. That has been
> submitted for review (https://codereview.chromium.org/593113003/)
> I want to revert this patch after chromium patch lands.

Sure. However, it has been over a week, so please do check that a revert of the
revert still applies, gets green try bots and uses the commit queue as per a
normal commit.

Powered by Google App Engine
This is Rietveld 408576698