Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 566883002: [DevTools] Report correct syntax error location for evaluated in console script (Closed)

Created:
6 years, 3 months ago by kozyatinskiy1
Modified:
6 years, 2 months ago
Reviewers:
vsevik, apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[DevTools] Report correct syntax error location for evaluated in console script Before this patch console message contains incorrect line number of code in InjectedScriptSource._evaluateOn function. With this patch this message contains correct script id, line number and column number. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183603

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M Source/core/inspector/InjectedScriptBase.cpp View 3 chunks +8 lines, -0 lines 2 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
kozyatinskiy1
Vsevolod, PTAL.
6 years, 3 months ago (2014-09-12 12:14:19 UTC) #2
kozyatinskiy1
On 2014/09/12 12:14:19, kozyatinskiy wrote: > Vsevolod, PTAL. Friendly ping! :)
6 years, 2 months ago (2014-10-03 09:48:52 UTC) #6
apavlov
The change looks sane :) https://codereview.chromium.org/566883002/diff/80001/Source/core/inspector/InjectedScriptBase.cpp File Source/core/inspector/InjectedScriptBase.cpp (right): https://codereview.chromium.org/566883002/diff/80001/Source/core/inspector/InjectedScriptBase.cpp#newcode77 Source/core/inspector/InjectedScriptBase.cpp:77: if (i == 0 ...
6 years, 2 months ago (2014-10-03 09:54:43 UTC) #8
kozyatinskiy1
https://codereview.chromium.org/566883002/diff/80001/Source/core/inspector/InjectedScriptBase.cpp File Source/core/inspector/InjectedScriptBase.cpp (right): https://codereview.chromium.org/566883002/diff/80001/Source/core/inspector/InjectedScriptBase.cpp#newcode77 Source/core/inspector/InjectedScriptBase.cpp:77: if (i == 0 && scriptId == originScriptId) On ...
6 years, 2 months ago (2014-10-03 10:08:27 UTC) #9
vsevik
lgtm
6 years, 2 months ago (2014-10-03 12:24:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/566883002/80001
6 years, 2 months ago (2014-10-03 12:29:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/30033)
6 years, 2 months ago (2014-10-03 14:43:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/566883002/80001
6 years, 2 months ago (2014-10-13 11:28:25 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 12:56:22 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:80001) as 183603

Powered by Google App Engine
This is Rietveld 408576698