Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/core/inspector/JavaScriptCallFrame.cpp

Issue 566883002: [DevTools] Report correct syntax error location for evaluated in console script (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 newValue.v8Value() 191 newValue.v8Value()
192 }; 192 };
193 return ScriptValue(scriptState, setVariableValueFunction->Call(callFrame, WT F_ARRAY_LENGTH(argv), argv)); 193 return ScriptValue(scriptState, setVariableValueFunction->Call(callFrame, WT F_ARRAY_LENGTH(argv), argv));
194 } 194 }
195 195
196 v8::Handle<v8::Object> JavaScriptCallFrame::createExceptionDetails(v8::Handle<v8 ::Message> message, v8::Isolate* isolate) 196 v8::Handle<v8::Object> JavaScriptCallFrame::createExceptionDetails(v8::Handle<v8 ::Message> message, v8::Isolate* isolate)
197 { 197 {
198 v8::Handle<v8::Object> exceptionDetails = v8::Object::New(isolate); 198 v8::Handle<v8::Object> exceptionDetails = v8::Object::New(isolate);
199 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "text"), message->Get ()); 199 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "text"), message->Get ());
200 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "url"), message->GetS criptOrigin().ResourceName()); 200 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "url"), message->GetS criptOrigin().ResourceName());
201 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "scriptId"), v8::Inte ger::New(isolate, message->GetScriptOrigin().ScriptID()->Value()));
201 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "line"), v8::Integer: :New(isolate, message->GetLineNumber())); 202 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "line"), v8::Integer: :New(isolate, message->GetLineNumber()));
202 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "column"), v8::Intege r::New(isolate, message->GetStartColumn())); 203 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "column"), v8::Intege r::New(isolate, message->GetStartColumn()));
203 if (!message->GetStackTrace().IsEmpty()) 204 if (!message->GetStackTrace().IsEmpty())
204 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "stackTrace"), me ssage->GetStackTrace()->AsArray()); 205 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "stackTrace"), me ssage->GetStackTrace()->AsArray());
205 else 206 else
206 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "stackTrace"), v8 ::Undefined(isolate)); 207 exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "stackTrace"), v8 ::Undefined(isolate));
207 return exceptionDetails; 208 return exceptionDetails;
208 } 209 }
209 210
210 void JavaScriptCallFrame::trace(Visitor* visitor) 211 void JavaScriptCallFrame::trace(Visitor* visitor)
211 { 212 {
212 visitor->trace(m_caller); 213 visitor->trace(m_caller);
213 } 214 }
214 215
215 } // namespace blink 216 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698