Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: chrome/browser/content_settings/host_content_settings_map.cc

Issue 566863005: Expose the Website Settings page in the Content Setting page if it is enabled via flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/host_content_settings_map.cc
diff --git a/chrome/browser/content_settings/host_content_settings_map.cc b/chrome/browser/content_settings/host_content_settings_map.cc
index 40b6fe1be7a169aa97e859c6fa75061111824b90..5cb97504afbcf6f9addb91385151dfa5b17f7c8e 100644
--- a/chrome/browser/content_settings/host_content_settings_map.cc
+++ b/chrome/browser/content_settings/host_content_settings_map.cc
@@ -201,10 +201,6 @@ ContentSetting HostContentSettingsMap::GetDefaultContentSetting(
}
}
- // The method GetDefaultContentSetting always has to return an explicit
- // value that is to be used as default. We here rely on the
- // DefaultProvider to always provide a value.
- NOTREACHED();
Bernhard Bauer 2014/09/15 09:13:49 Why is this not the case anymore?
Daniel Nishi 2014/09/15 16:57:27 If we ask for a default content setting for a cont
Bernhard Bauer 2014/09/15 17:05:38 Yeah, but the point of the DefaultProvider is that
Daniel Nishi 2014/09/15 17:43:53 In some cases, the idea of a default setting doesn
return CONTENT_SETTING_DEFAULT;
}

Powered by Google App Engine
This is Rietveld 408576698