Expose the Website Settings page in the Content Setting page if it is enabled via flag.

chrome/browser/content_settings/host_content_settings_map.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 183 matching lines @@
       continue;
     ContentSetting default_setting =
         GetDefaultContentSettingFromProvider(content_type, provider->second);
     if (default_setting != CONTENT_SETTING_DEFAULT) {
       if (provider_id)
         *provider_id = kProviderNames[provider->first];
       return default_setting;
     }
   }
 
-  // The method GetDefaultContentSetting always has to return an explicit
-  // value that is to be used as default. We here rely on the
-  // DefaultProvider to always provide a value.
-  NOTREACHED();

[Bernhard Bauer, 2014/09/15 09:13:49]

Why is this not the case anymore?

[Daniel Nishi, 2014/09/15 16:57:27]

If we ask for a default content setting for a content setting whose actual
default is CONTENT_SETTING_DEFAULT from the DefaultProvider, it will fall
through and trigger the NOTREACHED().

[Bernhard Bauer, 2014/09/15 17:05:38]

Yeah, but the point of the DefaultProvider is that it will always return a
(non-DEFAULT) setting... Why doesn't that happen?

[Daniel Nishi, 2014/09/15 17:43:53]

In some cases, the idea of a default setting doesn't make sense, like for
protocol handlers. In this case, the DefaultSettingsProvider returns the value
CONTENT_SETTING_DEFAULT.

   return CONTENT_SETTING_DEFAULT;
 }
 
 ContentSetting HostContentSettingsMap::GetContentSetting(
     const GURL& primary_url,
     const GURL& secondary_url,
     ContentSettingsType content_type,
     const std::string& resource_identifier) const {
   DCHECK(!ContentTypeHasCompoundValue(content_type));
   scoped_ptr<base::Value> value(GetWebsiteSetting(
@@ skipping 534 matching lines @@
   }
 
   NOTREACHED();
   return DEFAULT_PROVIDER;
 }
 
 content_settings::PrefProvider* HostContentSettingsMap::GetPrefProvider() {
   return static_cast<content_settings::PrefProvider*>(
       content_settings_providers_[PREF_PROVIDER]);
 }