Remove deprecated extension notification from ProcessManager.

Remove deprecated extension notification from ProcessManager.

This patch used EntensionRegistryObserver instead of DEPRECATED extension
NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED removed now.

BUG=411568
Committed: https://crrev.com/1bd52ffda33ffc5614dab8e3f3d677f0a528e763
Cr-Commit-Position: refs/heads/master@{#294799}

[Jitu( very slow this week), 2014-09-12 13:09:38]

jitendra.ks@samsung.com changed reviewers:
+ bauerb@chromium.org

[Jitu( very slow this week), 2014-09-12 13:09:40]

PTAL

[Bernhard Bauer, 2014-09-12 13:22:54]

LGTM, but please update the title to remove the [WIP] tag.

Also, I'm not an OWNER for these files.

[Jitu( very slow this week), 2014-09-12 13:31:01]

jitendra.ks@samsung.com changed reviewers:
+ rockot@chromium.org

[Jitu( very slow this week), 2014-09-12 13:31:01]

Dear Ken,

PTAL ...

[Jitu( very slow this week), 2014-09-12 15:47:47]

The CQ bit was checked by jitendra.ks@samsung.com

[Jitu( very slow this week), 2014-09-12 15:48:03]

The CQ bit was unchecked by jitendra.ks@samsung.com

[Ken Rockot(use gerrit already), 2014-09-12 17:03:45]

lgtm

[limasdf, 2014-09-12 23:12:47]

limasdf@gmail.com changed reviewers:
+ limasdf@gmail.com

[limasdf, 2014-09-12 23:12:47]

@rockot, Could you run memory test?

Because my try was failed because of Linux Asan Fail.
https://codereview.chromium.org/434593002/

[Ken Rockot(use gerrit already), 2014-09-12 23:50:49]

On 2014/09/12 23:12:47, limasdf wrote:
> @rockot, Could you run memory test?
> 
> Because my try was failed because of Linux Asan Fail.
> https://codereview.chromium.org/434593002/

Ah, Could be a lifetime issue with the registry or something. You can test this
by building with the asan=1 Gyp flag.

[Jitu( very slow this week), 2014-09-15 09:16:41]

The CQ bit was checked by jitendra.ks@samsung.com

[commit-bot: I haz the power, 2014-09-15 09:17:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566863002/20001

[commit-bot: I haz the power, 2014-09-15 09:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-15 09:34:00]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Jitu( very slow this week), 2014-09-15 10:32:49]

The CQ bit was checked by jitendra.ks@samsung.com

[commit-bot: I haz the power, 2014-09-15 10:33:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566863002/20001

[commit-bot: I haz the power, 2014-09-15 10:34:33]

Committed patchset #2 (id:20001) as 8bc90bb710835ff610b7a0641f1b776754ac3fec

[commit-bot: I haz the power, 2014-09-15 10:36:43]

Patchset 2 (id:??) landed as
https://crrev.com/1bd52ffda33ffc5614dab8e3f3d677f0a528e763
Cr-Commit-Position: refs/heads/master@{#294799}

[Alexander Potapenko, 2014-09-15 11:52:46]

On 2014/09/15 10:36:43, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/1bd52ffda33ffc5614dab8e3f3d677f0a528e763
> Cr-Commit-Position: refs/heads/master@{#294799}

This CL has introduced a use-after-free in
extensions::ExtensionRegistry::RemoveObserver
(http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28T...),
I'm about to revert.

[Jitu( very slow this week), 2014-09-15 12:01:13]

On 2014/09/15 11:52:46, Alexander Potapenko wrote:
> On 2014/09/15 10:36:43, I haz the power (commit-bot) wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/1bd52ffda33ffc5614dab8e3f3d677f0a528e763
> > Cr-Commit-Position: refs/heads/master@{#294799}
> 
> This CL has introduced a use-after-free in
> extensions::ExtensionRegistry::RemoveObserver
>
(http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28T...),
> I'm about to revert.

Dear Alexander,

How to run the memory tool on this. 
Please guide me.

[Alexander Potapenko, 2014-09-15 12:03:20]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/570073002/ by glider@chromium.org.

The reason for reverting is: One of the tests crashes with a UAF:
http://crbug.com/414245.

[Bernhard Bauer, 2014-09-15 13:47:17]

On 2014/09/15 12:01:13, Jitu wrote:
> On 2014/09/15 11:52:46, Alexander Potapenko wrote:
> > On 2014/09/15 10:36:43, I haz the power (commit-bot) wrote:
> > > Patchset 2 (id:??) landed as
> > > https://crrev.com/1bd52ffda33ffc5614dab8e3f3d677f0a528e763
> > > Cr-Commit-Position: refs/heads/master@{#294799}
> > 
> > This CL has introduced a use-after-free in
> > extensions::ExtensionRegistry::RemoveObserver
> >
>
(http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28T...),
> > I'm about to revert.
> 
> Dear Alexander,
> 
> How to run the memory tool on this. 
> Please guide me.

Why did you commit this in the first place without running ASAN tests, after you
were explicitly asked to do so? If you don't know how to run memory tests, ask
someone, and do it *before* you commit a CL.

FWIW, comment #11 tells you how to enable ASAN. Also, the link above is output
from a memory test, which should give you some information too.

[Jitu( very slow this week), 2014-09-15 13:49:47]

On 2014/09/15 13:47:17, Bernhard Bauer wrote:
> On 2014/09/15 12:01:13, Jitu wrote:
> > On 2014/09/15 11:52:46, Alexander Potapenko wrote:
> > > On 2014/09/15 10:36:43, I haz the power (commit-bot) wrote:
> > > > Patchset 2 (id:??) landed as
> > > > https://crrev.com/1bd52ffda33ffc5614dab8e3f3d677f0a528e763
> > > > Cr-Commit-Position: refs/heads/master@{#294799}
> > > 
> > > This CL has introduced a use-after-free in
> > > extensions::ExtensionRegistry::RemoveObserver
> > >
> >
>
(http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28T...),
> > > I'm about to revert.
> > 
> > Dear Alexander,
> > 
> > How to run the memory tool on this. 
> > Please guide me.
> 
> Why did you commit this in the first place without running ASAN tests, after
you
> were explicitly asked to do so? If you don't know how to run memory tests, ask
> someone, and do it *before* you commit a CL.
> 
> FWIW, comment #11 tells you how to enable ASAN. Also, the link above is output
> from a memory test, which should give you some information too.

Okay ... i will take care this in future.

I will try to fix this after running ASAN tests.

[limasdf, 2014-09-15 14:58:41]

On 2014/09/15 13:49:47, Jitu wrote:
> On 2014/09/15 13:47:17, Bernhard Bauer wrote:
> > On 2014/09/15 12:01:13, Jitu wrote:
> > > On 2014/09/15 11:52:46, Alexander Potapenko wrote:
> > > > On 2014/09/15 10:36:43, I haz the power (commit-bot) wrote:
> > > > > Patchset 2 (id:??) landed as
> > > > > https://crrev.com/1bd52ffda33ffc5614dab8e3f3d677f0a528e763
> > > > > Cr-Commit-Position: refs/heads/master@{#294799}
> > > > 
> > > > This CL has introduced a use-after-free in
> > > > extensions::ExtensionRegistry::RemoveObserver
> > > >
> > >
> >
>
(http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28T...),
> > > > I'm about to revert.
> > > 
> > > Dear Alexander,
> > > 
> > > How to run the memory tool on this. 
> > > Please guide me.
> > 
> > Why did you commit this in the first place without running ASAN tests, after
> you
> > were explicitly asked to do so? If you don't know how to run memory tests,
ask
> > someone, and do it *before* you commit a CL.
> > 
> > FWIW, comment #11 tells you how to enable ASAN. Also, the link above is
output
> > from a memory test, which should give you some information too.
> 
> Okay ... i will take care this in future.
> 
> I will try to fix this after running ASAN tests.

:: How to run the memory tool on this. 
The best way is to run trybot explicitly. But this requires a permission. to get
the permission you need some commit first.
Second way is to run ASan on local PC. See
http://www.chromium.org/developers/testing/addresssanitizer

About the problem.
the RemoveObserver should be called when a profile is shutdown, destructor of
ProcessManager is not a point that profile is shutdown. that's why we have a
ExtesnionRegistryObserver leak.

Perhaps, ChromeProfessManagerDelegate::OnProfileDestroyed is right point.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

[Jitu( very slow this week), 2014-09-16 11:08:59]

Patchset #3 (id:40001) has been deleted