Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java

Issue 566833003: Rename Cronet AsyncUrlRequestXYZ interfaces into UrlRequestXYZ. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java
diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java
new file mode 100644
index 0000000000000000000000000000000000000000..d8037a7da5883137525f6a02928554a5b4bed608
--- /dev/null
+++ b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java
@@ -0,0 +1,18 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+package org.chromium.net;
mmenke 2014/09/15 16:10:55 nit: Blank line before package
mef 2014/09/15 16:17:59 Done.
+
+import java.util.concurrent.Executor;
+
+/**
+ * Url request factory using Chromium HTTP stack implementation.
+ */
+public class CronetUrlRequestFactory implements UrlRequestFactory {
mef 2014/09/15 16:17:59 I've named this 'CronetUrlRequest[Factory]' to avi
mmenke 2014/09/15 16:23:32 I think we may want to combine the two factories,
+ @Override
+ public UrlRequest createRequest(String url, UrlRequestListener listener,
+ Executor executor) {
+ CronetUrlRequest request = new CronetUrlRequest();
mmenke 2014/09/15 16:10:55 Any reason not to just use: return new CronetUrlR
mef 2014/09/15 16:17:59 Done.
+ return request;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698