Use a std::string to store return value from FieldTrialList::FindFullName()

chrome/browser/chrome_browser_main.cc

Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index fc9377f532558f7b71848ea4c054b63bdf2c258d..2b75611a7429be9e564c7d6269156c4e50b65bf6 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -1384,14 +1384,14 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
     const char kEnabledHttpOnlyGroupName[] = "EnabledHttpOnly";
     const char kDisabledAllGroupName[] = "DisabledAll";
 
-    base::StringPiece sdch_trial_group =
+    std::string sdch_trial_group =
         base::FieldTrialList::FindFullName(kSdchFieldTrialName);
-    if (sdch_trial_group.starts_with(kEnabledAllGroupName)) {
+    if (sdch_trial_group == kEnabledAllGroupName) {

[mef, 2014/09/12 13:28:33]

I wonder if exact comparison is the right thing here. Could the trial groupname
be something like 'EnabledAll1234'? 

Would it make sense to just explicitly store return of
base::FieldTrialList::FindFullName(kSdchFieldTrialName) in the std::string
sdch_trial_group_name and make base::StringPiece sdch_trial_group based on it?

[Randy Smith (Not in Mondays), 2014/09/12 17:49:42]

Yeah ... I looked through the code and it looked like it would either be the
actual group name or a number, but I'm planning to try to merge this to M38, and
for that, it should be as close to the original code as possible.  Done.

       net::SdchManager::EnableSecureSchemeSupport(true);
       net::SdchManager::EnableSdchSupport(true);
-    } else if (sdch_trial_group.starts_with(kEnabledHttpOnlyGroupName)) {
+    } else if (sdch_trial_group == kEnabledHttpOnlyGroupName) {
       net::SdchManager::EnableSdchSupport(true);
-    } else if (sdch_trial_group.starts_with(kDisabledAllGroupName)) {
+    } else if (sdch_trial_group == kDisabledAllGroupName) {
       net::SdchManager::EnableSdchSupport(false);
     }
   }