Use a std::string to store return value from FieldTrialList::FindFullName()

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 1366 matching lines @@
 
   if (parsed_command_line().HasSwitch(switches::kEnableSdchOverHttps)) {
     net::SdchManager::EnableSecureSchemeSupport(true);
   } else {
     // Check SDCH field trial.
     const char kSdchFieldTrialName[] = "SDCH";
     const char kEnabledAllGroupName[] = "EnabledAll";
     const char kEnabledHttpOnlyGroupName[] = "EnabledHttpOnly";
     const char kDisabledAllGroupName[] = "DisabledAll";
 
-    base::StringPiece sdch_trial_group =
+    std::string sdch_trial_group =
         base::FieldTrialList::FindFullName(kSdchFieldTrialName);
-    if (sdch_trial_group.starts_with(kEnabledAllGroupName)) {
+    if (sdch_trial_group == kEnabledAllGroupName) {

[mef, 2014/09/12 13:28:33]

I wonder if exact comparison is the right thing here. Could the trial groupname
be something like 'EnabledAll1234'? 

Would it make sense to just explicitly store return of
base::FieldTrialList::FindFullName(kSdchFieldTrialName) in the std::string
sdch_trial_group_name and make base::StringPiece sdch_trial_group based on it?

[Randy Smith (Not in Mondays), 2014/09/12 17:49:42]

Yeah ... I looked through the code and it looked like it would either be the
actual group name or a number, but I'm planning to try to merge this to M38, and
for that, it should be as close to the original code as possible.  Done.

       net::SdchManager::EnableSecureSchemeSupport(true);
       net::SdchManager::EnableSdchSupport(true);
-    } else if (sdch_trial_group.starts_with(kEnabledHttpOnlyGroupName)) {
+    } else if (sdch_trial_group == kEnabledHttpOnlyGroupName) {
       net::SdchManager::EnableSdchSupport(true);
-    } else if (sdch_trial_group.starts_with(kDisabledAllGroupName)) {
+    } else if (sdch_trial_group == kDisabledAllGroupName) {
       net::SdchManager::EnableSdchSupport(false);
     }
   }
 
 #if defined(ENABLE_FULL_PRINTING) && !defined(OFFICIAL_BUILD)
   if (parsed_command_line().HasSwitch(switches::kDebugPrint)) {
     base::FilePath path =
         parsed_command_line().GetSwitchValuePath(switches::kDebugPrint);
     printing::PrintedDocument::set_debug_dump_path(path);
   }
@@ skipping 273 matching lines @@
   chromeos::CrosSettings::Shutdown();
 #endif
 #endif
 }
 
 // Public members:
 
 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
   chrome_extra_parts_.push_back(parts);
 }