chrome/browser/sync/glue/device_info.h - Issue 566623003: Refactor syncable DEVICE_INFO type from ChangeProcessor to SyncableService - part 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/device_info.h

Issue 566623003: Refactor syncable DEVICE_INFO type from ChangeProcessor to SyncableService - part 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit test fixes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc ('K') | « chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc ('k') | chrome/browser/sync/glue/device_info.cc » ('j') | chrome/browser/sync/glue/device_info_sync_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/device_info.h

diff --git a/chrome/browser/sync/glue/device_info.h b/chrome/browser/sync/glue/device_info.h

index a46e6508799a63c683522196d0633c96b3cd6c04..90d453ff968f38e1528615d0e61ff4108a138e93 100644

--- a/chrome/browser/sync/glue/device_info.h

+++ b/chrome/browser/sync/glue/device_info.h

@@ -78,6 +78,9 @@ class DeviceInfo {

// which extension APIs can expose to third party apps.

base::DictionaryValue* ToValue();

+ // Makes a copy of |DeviceInfo|.

+ DeviceInfo* Clone() const;

stanisc 2014/09/16 00:17:40 Would you rather have a copy constructor?

pavely 2014/09/17 23:04:38 Discussed in person. You can keep Clone, it depend

stanisc 2014/09/18 22:46:53 I decided to get rid of Clone. My next change woul

static sync_pb::SyncEnums::DeviceType GetLocalDeviceType();

// Creates a |DeviceInfo| object representing the local device and passes