Refactor syncable DEVICE_INFO type from ChangeProcessor to SyncableService - part 3.

chrome/browser/sync/glue/device_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_DEVICE_INFO_H_
 #define CHROME_BROWSER_SYNC_GLUE_DEVICE_INFO_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 60 matching lines @@
   // Apps can set ids for a device that is meaningful to them but
   // not unique enough so the user can be tracked. Exposing |guid|
   // would lead to a stable unique id for a device which can potentially
   // be used for tracking.
   void set_public_id(std::string id);
 
   // Converts the |DeviceInfo| values to a JS friendly DictionaryValue,
   // which extension APIs can expose to third party apps.
   base::DictionaryValue* ToValue();
 
+  // Makes a copy of |DeviceInfo|.
+  DeviceInfo* Clone() const;

[stanisc, 2014/09/16 00:17:40]

Would you rather have a copy constructor?

[pavely, 2014/09/17 23:04:38]

Discussed in person.
You can keep Clone, it depends on typical usage scenario.
Return scoped_ptr<DeviceInfo> instead of raw pointer though.
On 2014/09/16 00:17:40, stanisc wrote:

[stanisc, 2014/09/18 22:46:53]

I decided to get rid of Clone. My next change would make it unnecessary anyway.

+
   static sync_pb::SyncEnums::DeviceType GetLocalDeviceType();
 
   // Creates a |DeviceInfo| object representing the local device and passes
   // it as parameter to the callback.
   static void CreateLocalDeviceInfo(
       const std::string& guid,
       const std::string& signin_scoped_device_id,
       base::Callback<void(const DeviceInfo& local_info)> callback);
 
   // Gets the local device name and passes it as a parameter to callback.
@@ skipping 34 matching lines @@
   // ids in that the same device will have different id for different apps
   // and they are also reset when app/extension is uninstalled.
   std::string public_id_;
 
   DISALLOW_COPY_AND_ASSIGN(DeviceInfo);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_DEVICE_INFO_H_