Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issue 566553002: Add script streaming API. (Closed)

Created:
6 years, 3 months ago by marja
Modified:
6 years, 3 months ago
CC:
Paweł Hajdan Jr., v8-dev
Project:
v8
Visibility:
Public.

Description

Add script streaming API. Blink will use this API to stream script data into V8 as the scripts load. During loading, V8 can already parse the scripts. They will be then compiled and executed when the loading is complete. This is a reincarnation of https://codereview.chromium.org/366153002/ with fixes. BUG= R=jochen@chromium.org, rossberg@chromium.org, svenpanne@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23904

Patch Set 1 #

Patch Set 2 : utf-8 test fixes #

Patch Set 3 : size_t fix #

Patch Set 4 : rebased #

Patch Set 5 : moar #

Patch Set 6 : todo #

Patch Set 7 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1015 lines, -78 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M include/v8.h View 3 chunks +94 lines, -0 lines 0 comments Download
M src/api.cc View 3 chunks +98 lines, -0 lines 0 comments Download
A src/background-parsing-task.h View 1 chunk +67 lines, -0 lines 0 comments Download
A src/background-parsing-task.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M src/compiler.h View 6 chunks +23 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 2 3 4 5 6 12 chunks +67 lines, -28 lines 0 comments Download
M src/parser.h View 4 chunks +9 lines, -7 lines 0 comments Download
M src/parser.cc View 8 chunks +76 lines, -24 lines 0 comments Download
M src/scanner-character-streams.h View 2 chunks +43 lines, -0 lines 0 comments Download
M src/scanner-character-streams.cc View 1 2 3 4 5 4 chunks +167 lines, -19 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 1 chunk +305 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
marja
FYI, here's the fixed version of the streaming API cl. Patch set 1 is the ...
6 years, 3 months ago (2014-09-11 12:04:34 UTC) #1
jochen (gone - plz use gerrit)
lgtm assuming tryjobs are happy :)
6 years, 3 months ago (2014-09-11 12:05:00 UTC) #2
marja
Offline discussion with jochen@ and svenpanne@ about the size_t fix: - The correct type for ...
6 years, 3 months ago (2014-09-12 08:43:42 UTC) #4
marja
6 years, 3 months ago (2014-09-12 09:12:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #7 (id:140001) manually as 23904 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698