Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 566433004: Add notification and observer to copy the file between other users. (Closed)

Created:
6 years, 3 months ago by iseki
Modified:
6 years, 3 months ago
Reviewers:
yoshiki, fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add notification and observer to copy the file between other users. * NotificationRegister and NotificationObserver is need to collect file information. * This CL is related to https://codereview.chromium.org/530553006 BUG=412691 Committed: https://crrev.com/0407ff6ae1510a622f422959af156f35860c9e30 Cr-Commit-Position: refs/heads/master@{#294346}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.h View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 3 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
iseki
Please take a look.
6 years, 3 months ago (2014-09-11 03:24:19 UTC) #2
yoshiki
lgtm
6 years, 3 months ago (2014-09-11 04:43:25 UTC) #3
fukino
https://codereview.chromium.org/566433004/diff/1/chrome/browser/chromeos/extensions/file_manager/event_router.cc File chrome/browser/chromeos/extensions/file_manager/event_router.cc (right): https://codereview.chromium.org/566433004/diff/1/chrome/browser/chromeos/extensions/file_manager/event_router.cc#newcode968 chrome/browser/chromeos/extensions/file_manager/event_router.cc:968: file_browser_private::OnProfileAdded::kEventName, I think there is no listener for onProfileAdded ...
6 years, 3 months ago (2014-09-11 05:00:16 UTC) #4
iseki
Thank you for your review. https://codereview.chromium.org/566433004/diff/1/chrome/browser/chromeos/extensions/file_manager/event_router.cc File chrome/browser/chromeos/extensions/file_manager/event_router.cc (right): https://codereview.chromium.org/566433004/diff/1/chrome/browser/chromeos/extensions/file_manager/event_router.cc#newcode968 chrome/browser/chromeos/extensions/file_manager/event_router.cc:968: file_browser_private::OnProfileAdded::kEventName, On 2014/09/11 05:00:16, ...
6 years, 3 months ago (2014-09-11 05:15:52 UTC) #5
fukino
On 2014/09/11 05:15:52, iseki wrote: > Thank you for your review. > > https://codereview.chromium.org/566433004/diff/1/chrome/browser/chromeos/extensions/file_manager/event_router.cc > ...
6 years, 3 months ago (2014-09-11 06:13:07 UTC) #6
fukino
On 2014/09/11 05:15:52, iseki wrote: > Thank you for your review. > > https://codereview.chromium.org/566433004/diff/1/chrome/browser/chromeos/extensions/file_manager/event_router.cc > ...
6 years, 3 months ago (2014-09-11 06:13:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566433004/20001
6 years, 3 months ago (2014-09-11 06:24:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 68c0136eacf331607ae023af902ad428a10cf39d
6 years, 3 months ago (2014-09-11 07:30:29 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 07:40:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0407ff6ae1510a622f422959af156f35860c9e30
Cr-Commit-Position: refs/heads/master@{#294346}

Powered by Google App Engine
This is Rietveld 408576698