Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 530553006: Remove "Move window to..." from gear menu. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove "Move window to..." from gear menu. This CL removes: - "Move window to..." menu item from the gear menu. - Remove APIs fileBrowserPrivate.onProfileAdded and fileBrowserPrivate.onDesktopChanged as they are used only for updating gear menu. - Remove corresponding tests. BUG=408965 TEST=run browser_test, unit_tests TBR=benwells@chromium.org # TBRing for just removing unused events from file_browser_private.idl Committed: https://crrev.com/46c5b30d31a0fa9b5f8200af08d80babbf305d41 Cr-Commit-Position: refs/heads/master@{#292860}

Patch Set 1 #

Messages

Total messages: 13 (4 generated)
fukino
yoshiki@, could you take a look? According to the comment #7 in Issue 408816, the ...
6 years, 3 months ago (2014-09-01 08:39:17 UTC) #2
yoshiki
lgtm
6 years, 3 months ago (2014-09-01 09:01:24 UTC) #3
fukino
On 2014/09/01 09:01:24, yoshiki wrote: > lgtm Thanks!
6 years, 3 months ago (2014-09-01 09:02:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/530553006/1
6 years, 3 months ago (2014-09-01 09:03:03 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-01 10:01:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8005)
6 years, 3 months ago (2014-09-01 10:05:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/530553006/1
6 years, 3 months ago (2014-09-01 11:00:22 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2325ca4811ebbc9228331c621c5dc22d475b918d
6 years, 3 months ago (2014-09-01 11:05:37 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46c5b30d31a0fa9b5f8200af08d80babbf305d41
Cr-Commit-Position: refs/heads/master@{#292860}

Powered by Google App Engine
This is Rietveld 408576698