Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 565843002: ServiceWorker: Move tracking code to count only pages controlled by SW (Closed)

Created:
6 years, 3 months ago by shimazu
Modified:
6 years, 3 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org, kenjibaheux
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Move tracking code to count only pages controlled by SW BUG=N/A TEST=N/A Committed: https://crrev.com/d8a14b38c4934f78153ee74a0a6f621a84b6017e Cr-Commit-Position: refs/heads/master@{#294560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
shimazu
Could you review this patch?
6 years, 3 months ago (2014-09-12 06:20:30 UTC) #2
nhiroki
+kenjibaheux@ to CC for your information
6 years, 3 months ago (2014-09-12 06:26:31 UTC) #3
nhiroki
LGTM, thanks!
6 years, 3 months ago (2014-09-12 06:26:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565843002/1
6 years, 3 months ago (2014-09-12 07:23:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as d72ca31f76b253ee5d4c107be1ed003654bd308e
6 years, 3 months ago (2014-09-12 09:31:42 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 09:35:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8a14b38c4934f78153ee74a0a6f621a84b6017e
Cr-Commit-Position: refs/heads/master@{#294560}

Powered by Google App Engine
This is Rietveld 408576698