Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 565843002: ServiceWorker: Move tracking code to count only pages controlled by SW (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_controllee_request_handler.cc
diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc
index 3cc931ad6c64790292baa3258b0a9490f88bb87c..382ece5ebd2700d02cadf5e26453b266c440eb69 100644
--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc
+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc
@@ -148,8 +148,6 @@ ServiceWorkerControlleeRequestHandler::DidLookupRegistrationForMainResource(
}
DCHECK(registration.get());
- ServiceWorkerMetrics::CountControlledPageLoad();
-
// Initiate activation of a waiting version.
// Usually a register job initiates activation but that
// doesn't happen if the browser exits prior to activation
@@ -191,6 +189,8 @@ ServiceWorkerControlleeRequestHandler::DidLookupRegistrationForMainResource(
return;
}
+ ServiceWorkerMetrics::CountControlledPageLoad();
+
provider_host_->AssociateRegistration(registration.get());
job_->ForwardToServiceWorker();
TRACE_EVENT_ASYNC_END2(
@@ -211,6 +211,9 @@ void ServiceWorkerControlleeRequestHandler::OnVersionStatusChanged(
job_->FallbackToNetwork();
return;
}
+
+ ServiceWorkerMetrics::CountControlledPageLoad();
+
provider_host_->AssociateRegistration(registration);
job_->ForwardToServiceWorker();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698