Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: tools/telemetry/telemetry/core/possible_browser.py

Issue 565803002: Removing browser.Start() and instead starts the browser at the point of creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: resolve merge conflict Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/extension_unittest.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/possible_browser.py
diff --git a/tools/telemetry/telemetry/core/possible_browser.py b/tools/telemetry/telemetry/core/possible_browser.py
index 204b1f860c0f6c52aa51c4936ffafa7f2d89eb5b..db9f7ac6e4fbf783009a7be305b5d149c41c05e0 100644
--- a/tools/telemetry/telemetry/core/possible_browser.py
+++ b/tools/telemetry/telemetry/core/possible_browser.py
@@ -18,6 +18,10 @@ class PossibleBrowser(object):
self._supports_tab_control = supports_tab_control
self._platform = None
self._platform_backend = None
+ self._archive_path = None
+ self._append_to_existing_wpr = False
+ self._make_javascript_deterministic = True
+ self._credentials_path = None
def __repr__(self):
return 'PossibleBrowser(browser_type=%s)' % self.browser_type
@@ -65,3 +69,12 @@ class PossibleBrowser(object):
def last_modification_time(self):
return -1
+
+ def SetReplayArchivePath(self, archive_path, append_to_existing_wpr,
+ make_javascript_deterministic):
+ self._archive_path = archive_path
+ self._append_to_existing_wpr = append_to_existing_wpr
+ self._make_javascript_deterministic = make_javascript_deterministic
+
+ def SetCredentialsPath(self, credentials_path):
+ self._credentials_path = credentials_path
« no previous file with comments | « tools/telemetry/telemetry/core/extension_unittest.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698