tools/telemetry/telemetry/core/extension_unittest.py - Issue 565803002: Removing browser.Start() and instead starts the browser at the point of creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/extension_unittest.py

Issue 565803002: Removing browser.Start() and instead starts the browser at the point of creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve merge conflict Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/extension_unittest.py

diff --git a/tools/telemetry/telemetry/core/extension_unittest.py b/tools/telemetry/telemetry/core/extension_unittest.py

index 23cac65334bda36c1cdfca0b12e4f82e6e3830bd..77e44e382af9b2ddf184557f08dac8963d1b94cf 100644

--- a/tools/telemetry/telemetry/core/extension_unittest.py

+++ b/tools/telemetry/telemetry/core/extension_unittest.py

@@ -32,7 +32,6 @@ class ExtensionTest(unittest.TestCase):

# May not find a browser that supports extensions.

return False

self._browser = browser_to_create.Create()

- self._browser.Start()

self._extension = self._browser.extensions[load_extension]

self._extension_id = load_extension.extension_id

self.assertTrue(self._extension)

@@ -124,7 +123,6 @@ class MultipleExtensionTest(unittest.TestCase):

# May not find a browser that supports extensions.

if browser_to_create:

self._browser = browser_to_create.Create()

- self._browser.Start()

def tearDown(self):

if self._browser:

« no previous file with comments | « tools/telemetry/telemetry/core/browser_credentials.py ('k') | tools/telemetry/telemetry/core/possible_browser.py » ('j') | no next file with comments »